Avoid unnecessary/misleading warning in refineChromPeaks - #835
Merged
Conversation
- Drop row names of intermediate objects to avoid unnecessary warning message in `refineChromPeaks,XcmsExperiment,MergeNeighboringPeaksParam`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a duplicate of PR #834 , only for the release branch, instead of the devel branch. Info on the PR:
refineChromPeaks,XcmsExperiment,MergeNeighboringPeaksParamwas showing a warning about duplicated row names, but this was thrown by an internal merging of results - on temporarydata.frames/sub sets of thechromPeakData(). This PR is removing the row names from these intermediate objects. The final (real) row names ofchromPeakData()were (and are) assigned correctly at the end of the call.