fix(web): keep the stored value when a secret edit leaves it blank - #18
Merged
Merged
Conversation
Updating a secret demanded a replacement value even when only the note or tags were changing, and the value field promised plaintext is "never shown after save" — which the reveal control disproves. - PATCH /api/v1/secrets/:secretId no longer requires `value`. Without one, SecretService edits notes and tags in place: no new secret version, no environment config-version bump, so runtime clients are not forced to re-fetch for a note. A change note sent without a value is rejected rather than silently dropped. - The editor's value field is optional in edit mode, explains that blank keeps the current value, hides the change note until a value is typed, and submits as "Save changes" instead of "Create new version". - Drops the inaccurate "never shown after save" placeholder. Also lands the consistency-panel work that was pending in the working tree: the cross-environment diff collapses behind "Show details", and cellFindings stops badging the environments that hold a key as missing it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N3xGYJfHiv11Snq9p98Z4Q
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Editing a secret to change only its note or tags forced you to re-enter a replacement value, and the value field claimed plaintext is "never shown after save" — which the reveal control disproves.
PATCH /api/v1/secrets/:secretIdno longer requiresvalue. Without one,SecretService.updateedits notes and tags in place: no newsecret_versionsrow, and no environmentconfig_versionbump, so runtime consumers are not forced to re-fetch for a note change. AchangeNotesent without a value is rejected asINVALID_INPUTrather than silently dropped.Also lands the consistency-panel work that was pending in the working tree: the cross-environment diff collapses behind Show details, and
cellFindingsstops badging the environments that hold a key as missing it.Tests
value.docs:checkpass locally.docs/openapi.jsonregenerated. The Postgres suites could not run locally (no Postgres or Docker on this machine) — CI covers them.🤖 Generated with Claude Code
https://claude.ai/code/session_01N3xGYJfHiv11Snq9p98Z4Q