chore(tooltip): useId를 @sipe-team/hooks로 교체 - #319
Conversation
🦋 Changeset detectedLatest commit: d0720b0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
pnpm-lock.yaml still referenced jest-axe/@types/jest-axe that were removed from packages/tooltip/package.json, causing CI's --frozen-lockfile install step to fail.
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
요약
Tooltip 내부 id 생성 방식을 React의 raw
useId대신@sipe-team/hooks의useId로 교체합니다. Accordion에 이미 적용된 공유 훅과 동일한 패턴으로 통일하기 위함이며, 생성되는 id에side-접두어가 붙는 것 외에 동작 변화는 없습니다.변경 사항
Tooltip.tsx의useIdimport를react에서@sipe-team/hooks로 교체@sipe-team/tooltip패키지에@sipe-team/hooks의존성 추가