feat: make sinon.restoreObject idempotent

src/sinon/restore-object.js

@@ -15,5 +15,5 @@ export default function restoreObject(object) {
         );
     }
 
-    return walkObject(restore, object, filter);
+    return walkObject(restore, object, filter, false);
 }

src/sinon/util/core/walk-object.js

@@ -24,9 +24,10 @@ import walk from "./walk.js";
  * @param {ObjectMutator} mutator called on each property
  * @param {object} object the object we are walking over
  * @param {ObjectFilter} filter a predicate (boolean function) that will decide whether or not to apply the mutator to the current property
+ * @param {boolean} [strict] when true (default), throws if the mutator was never applied to any property
  * @returns {void} nothing
  */
-const walkObject = function (mutator, object, filter) {
+const walkObject = function (mutator, object, filter, strict = true) {
     let called = false;
     const name = functionName(mutator);
 
@@ -56,7 +57,7 @@ const walkObject = function (mutator, object, filter) {
         }
     });
 
-    if (!called) {
+    if (!called && strict) {
         throw new Error(
             `Found no methods on object to which we could apply mutations`,
         );

test/src/restore-object-test.js

@@ -35,19 +35,15 @@ describe("restore-object", function () {
         );
     });
 
-    it("throws with no spies or stubs", function () {
-        assert.exception(
-            function () {
-                restoreObject({
-                    catpants: function () {},
-                    meh: "okay",
-                });
-            },
-            {
-                message:
-                    "Found no methods on object to which we could apply mutations",
-            },
-        );
+    it("is a no-op with no spies or stubs", function () {
+        const object = {
+            catpants: function () {},
+            meh: "okay",
+        };
+
+        refute.exception(function () {
+            restoreObject(object);
+        });
     });
 
     it("works with mixed spies and stubs", function () {