Skip to content

Allow the LocalBuildJobRunner to continue on task failure - #1022

Open
pmachapman wants to merge 1 commit into
mainfrom
handle_build_runner_faults
Open

Allow the LocalBuildJobRunner to continue on task failure#1022
pmachapman wants to merge 1 commit into
mainfrom
handle_build_runner_faults

Conversation

@pmachapman

@pmachapman pmachapman commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Fixes #1020

I was able to recreate this locally by stopping the mongo-1 docker container, then restarting it after a couple of minutes.


This change is Reviewable

@pmachapman
pmachapman requested a review from Enkidu93 August 6, 2026 03:40
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.92308% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.01%. Comparing base (a75539c) to head (2fc7133).

Files with missing lines Patch % Lines
...val.Machine.Shared/Services/LocalBuildJobRunner.cs 76.92% 8 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1022   +/-   ##
=======================================
  Coverage   72.00%   72.01%           
=======================================
  Files         386      386           
  Lines       20886    20912   +26     
  Branches     2778     2781    +3     
=======================================
+ Hits        15040    15060   +20     
- Misses       4737     4742    +5     
- Partials     1109     1110    +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ddaspit ddaspit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddaspit reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Enkidu93 and pmachapman).


src/Machine/src/Serval.Machine.Shared/Services/LocalBuildJobRunner.cs line 116 at r1 (raw file):

                // If one of the tasks has faulted, cancel the other
                if (completedTask.IsFaulted)

Is this scenario testable?

@Enkidu93 Enkidu93 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Enkidu93 reviewed all commit messages and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pmachapman).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The build queue does not recover after an Internet outage

4 participants