Allow the LocalBuildJobRunner to continue on task failure - #1022
Allow the LocalBuildJobRunner to continue on task failure#1022pmachapman wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1022 +/- ##
=======================================
Coverage 72.00% 72.01%
=======================================
Files 386 386
Lines 20886 20912 +26
Branches 2778 2781 +3
=======================================
+ Hits 15040 15060 +20
- Misses 4737 4742 +5
- Partials 1109 1110 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ddaspit
left a comment
There was a problem hiding this comment.
@ddaspit reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Enkidu93 and pmachapman).
src/Machine/src/Serval.Machine.Shared/Services/LocalBuildJobRunner.cs line 116 at r1 (raw file):
// If one of the tasks has faulted, cancel the other if (completedTask.IsFaulted)
Is this scenario testable?
Enkidu93
left a comment
There was a problem hiding this comment.
@Enkidu93 reviewed all commit messages and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pmachapman).
Fixes #1020
I was able to recreate this locally by stopping the mongo-1 docker container, then restarting it after a couple of minutes.
This change is