Skip to content

Progressive data structures and tests EIP-7916, EIP-8016 #8505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
michaelsproul wants to merge 14 commits into from
Closed

Progressive data structures and tests EIP-7916, EIP-8016 #8505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
86f8c2e
EIP-7916: ProgressiveList and tests
michaelsproul Dec 1, 2025
d7ebdeb
Merge remote-tracking branch 'origin/unstable' into progressive-list-…
michaelsproul Dec 8, 2025
9e15231
Test runners for basic progressive containers and bitlists
michaelsproul Dec 10, 2025
fffd203
Rest of the progressive container tests
michaelsproul Dec 18, 2025
30289cd
Remove path patches
michaelsproul Dec 18, 2025
6b5d878
Compatible union tests
michaelsproul Jan 12, 2026
9aad3c6
Passing on v1.7.1-alpha.1
michaelsproul Jan 12, 2026
e98b6db
Merge remote-tracking branch 'origin/unstable' into progressive-list-…
michaelsproul Jan 12, 2026
ecd207f
Remove selector attribute duplication! Yay!
michaelsproul Jan 13, 2026
be9d697
Fix Bitfield type inference
macladson Feb 12, 2026
e9d53ea
Merge branch 'unstable' into progressive-list-tests
macladson Feb 12, 2026
827ff95
Enable all ssz tests
macladson Feb 13, 2026
72723b2
Merge branch 'unstable' into progressive-list-tests
macladson May 27, 2026
0d64c6f
Merge branch 'unstable' into progressive-list-tests
macladson Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 16 additions & 20 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,4 +275,9 @@ debug = true

[patch.crates-io]
quick-protobuf = { git = "https://github.com/sigp/quick-protobuf.git", rev = "87c4ccb9bb2af494de375f5f6c62850badd26304" }

# FIXME(sproul): REMOVE patch
milhouse = { git = "https://github.com/sigp/milhouse", branch = "progressive-list" }
ethereum_ssz = { git = "https://github.com/sigp/ethereum_ssz", branch = "progressive" }
ethereum_ssz_derive = { git = "https://github.com/sigp/ethereum_ssz", branch = "progressive" }
tree_hash = { git = "https://github.com/sigp/tree_hash", branch = "progressive" }
tree_hash_derive = { git = "https://github.com/sigp/tree_hash", branch = "progressive" }
5 changes: 4 additions & 1 deletion consensus/state_processing/src/per_block_processing/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,10 @@ async fn invalid_attestation_bad_aggregation_bitfield_len() {
.next()
.unwrap()
.aggregation_bits_electra_mut()
.unwrap() = Bitfield::with_capacity(spec.target_committee_size).unwrap();
.unwrap() = Bitfield::<
ssz_types::length::Variable<<MainnetEthSpec as EthSpec>::MaxValidatorsPerSlot>,
>::with_capacity(spec.target_committee_size)
.unwrap();

let mut ctxt = ConsensusContext::new(state.slot());
let result = process_operations::process_attestations(
Expand Down
1 change: 1 addition & 0 deletions testing/ef_tests/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ compare_fields = { workspace = true }
context_deserialize = { workspace = true }
educe = { workspace = true }
eth2_network_config = { workspace = true }
ethereum_hashing = { workspace = true } # FIXME(sproul): remove
ethereum_ssz = { workspace = true }
ethereum_ssz_derive = { workspace = true }
execution_layer = { workspace = true }
Expand Down
7 changes: 0 additions & 7 deletions testing/ef_tests/check_all_files_accessed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,13 +60,6 @@
"tests/.*/gloas/ssz_static/ExecutionPayloadHeader/.*",
# ForkChoiceNode is internal to fork choice and probably doesn't need SSZ tests.
"tests/.*/gloas/ssz_static/ForkChoiceNode/.*",
# EIP-7916 is still in draft and hasn't been implemented yet https://eips.ethereum.org/EIPS/eip-7916
"tests/general/phase0/ssz_generic/progressive_bitlist",
"tests/general/phase0/ssz_generic/basic_progressive_list",
"tests/general/phase0/ssz_generic/containers/.*/ProgressiveBitsStruct.*",
"tests/general/phase0/ssz_generic/containers/.*/ProgressiveTestStruct.*",
"tests/general/phase0/ssz_generic/progressive_containers/.*",
"tests/general/phase0/ssz_generic/compatible_unions/.*",
# Ignore full epoch tests for now (just test the sub-transitions).
"tests/.*/.*/epoch_processing/.*/pre_epoch.ssz_snappy",
"tests/.*/.*/epoch_processing/.*/post_epoch.ssz_snappy",
Expand Down
Loading
Loading