reduce GetIncidents resource usage - #276
Merged
MovieStoreGuy merged 4 commits intoAug 20, 2026
Merged
MovieStoreGuy merged 4 commits into
MovieStoreGuy merged 4 commits into
Conversation
michael-burt
changed the title
michael-burt
commented
Aug 19, 2026
michael-burt
marked this pull request as ready for review
August 19, 2026 16:07
This reverts commit 97eb8c9.
michael-burt
changed the title
MovieStoreGuy
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Through profiling I found two performance issues in GetIncidents (https://github.com/signalfx/signalfx-go/blob/v1.63.0/incident.go#L39-L58).