Cancel stop confirmation on Esc#1179
Open
Tomasz Turkowski (tturkowski) wants to merge 1 commit into
Open
Conversation
Tomasz Turkowski (tturkowski)
requested review from
Anne Hintzpeter (Ant1gua) and
Soner (shyim)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Pressing
Escon the "Leaving the workspace" stop confirmation now cancels it, same as navigating to "Cancel" and pressing Enter. The footer hint was updated to showescas a shortcut.Why it changed?
Previously users had to arrow/tab over to the "Cancel" button and press Enter just to back out of the dialog.
Escis more natural way to dismiss a confirmation, so this makes canceling faster.How it was tested?
Updated the existing unit test to assert
Escemits a cancel result.Related issue
None.