Repository navigation
Remove profile cipher output stream which contains unsafe cipher usage - #1654
Merged
Merged
Conversation
ThomasSession
approved these changes
Oct 31, 2025
Merged
SessionHero01
added a commit
that referenced
this pull request
Nov 3, 2025
* Bump db migration version * Fix deterministic encryption * Fixing timestamp update in SMS table * Moving the timeout to the config wait only * Fixed avatar processing (#1649) * [SES-4799] - Re-upload avatar when renew fails with expired files (#1653) * Remove profile cipher output stream which contains unsafe cipher usage (#1654) * Fix a couple of avatar processing issues (#1655) --------- Co-authored-by: ThomasSession <thomas.r@getsession.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This hopefully fixes one of the decryption errors some users have been experiencing.
Basically we will do the encryption in one go, and within the cipher lock (that's what
AESGCM.encryptis doing).