-
Notifications
You must be signed in to change notification settings - Fork 41
Adding the zero element to the generating set for graph inverse semigroups with at most one vertex. #1216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Adding the zero element to the generating set for graph inverse semigroups with at most one vertex. #1216
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
852754a
pausing to work on something else
joe-dw 502ec98
pausing to work on something else
joe-dw 8aa0a97
Merge branch 'GIS-with-one-vertex' of https://github.com/joe-dw/semig…
joe-dw c348b7e
Switched digraph to empty digraph for group and Rees matrix isomorphi…
joe-dw 4b3eaf4
Fix: GraphInverseSemigroup(Digraph([])) has no vertices
joe-dw 014ea36
Refactoring, comments and lint
joe-dw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This'd be more compact as (a properly formatted, and working version of):
if the order of the generators is not important, then you could conditionally add the zero to
inv_gensbefore populatinggens. I haven't checked that this actually works.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added it at the end as there are test cases that use the fact that, for any i less than the number of edges,
S.i = e_iAnd this way it shouldn't break anything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that makes sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will implement your changes and add some comments