Consistent ordering of roles on the project roles admin page - #2731
Merged
Conversation
Order the role fields to match the project overview page and the RoleType declaration order: PALs, project administrators, asset housekeepers, asset gatekeepers.
PALs are the least relevant of the roles, so list them last on both the project overview and the project roles admin page.
stuzart
marked this pull request as draft
August 27, 2026 13:07
Project coordinators were provided by the ProjectPosition model, which was removed in #880. Project never defines project_coordinators, so the respond_to? guard on the show page is always false and the block never renders, making projects_helper#project_coordinators_link_list dead too.
fbacall
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2727
The roles on the Administering the project roles page were listed as Project administrators, Asset gatekeepers, Asset housekeepers, PALs — while the project overview page lists them as PALs, Project administrators, Asset housekeepers, Asset gatekeepers. Having asset gatekeepers and housekeepers swapped between the two views makes it easy to assign someone to the wrong role.
Both views now use the same order, with PALs last as the least relevant of the roles:
Visibility of each role is unchanged — the PALs field on the admin page is still restricted to site administrators, and on the overview page the housekeepers and gatekeepers are still only shown to members and site administrators.
Also included, as a separate commit, is the removal of the unused project coordinators code that sat alongside these roles on the overview page. Project coordinators came from the
ProjectPositionmodel, which was removed in #880;Projectnever definesproject_coordinators, so therespond_to?guard on the show page is always false and the block never renders.