2646 missing validation on template level - #2663
Draft
kdp-cloud wants to merge 19 commits into
Draft
Conversation
kdp-cloud
commented
Jul 9, 2026
kdp-cloud
commented
Collaborator
- Adds validation on the template level
- Closes Missing validation on template level #2646
- Adds validation on the ISA tags
- Closes Missing ISA Tag validation in template attributes #2645
- Use partially the validation rules of the sample type model
It is pointless to run the consequent validation methods, which are based on the level.
`find_by` can return `nil` in case not found
kdp-cloud
force-pushed
the
2646-missing-validation-on-template-level
branch
from
August 26, 2026 14:09
6017901 to
67355cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.