Issue 2919 add a manual check for referential integrity - #2946
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2946 +/- ##
==========================================
- Coverage 98.07% 98.05% -0.03%
==========================================
Files 75 76 +1
Lines 8589 8651 +62
==========================================
+ Hits 8424 8483 +59
- Misses 165 168 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This Pull Request is not linked to an issue. To ensure our community is able to accurately track resolved issues, please link any issue that will be closed by this PR! |
amontanez24
left a comment
amontanez24
left a comment
There was a problem hiding this comment.
@nemanja-vujic Can you add "resolves #2919" to the description of this PR. That will close the issue when the PR is merged
| if table_name == relationship['child_table_name'] and child_foreign_key == list( | ||
| foreign_key_names | ||
| ): |
There was a problem hiding this comment.
will this fail if the foreign key names aren't in the same order? For example ['colA', 'colB', 'colC'] instead of ['colB', 'colC', 'colA'] ? I think those should still match
There was a problem hiding this comment.
Right, switched to comparing with sets and uses column order for the lookup. Added a test for this
…mes arent in the same order Add test for ref integrity with reordered composite key
5 participants
Resolves #2919