Issue 2921 and 2920 overlaping check - #2938
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2938 +/- ##
=======================================
Coverage 98.07% 98.07%
=======================================
Files 76 76
Lines 8666 8730 +64
=======================================
+ Hits 8499 8562 +63
- Misses 167 168 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sarahmish
reviewed
Aug 6, 2026
| real_values = real_data[table_name][column_names].copy() | ||
| synthetic_values = synthetic_data[table_name][column_names].copy() | ||
| for column_name in column_names: | ||
| real_values[column_name], synthetic_values[column_name] = _align_dtypes( |
Contributor
There was a problem hiding this comment.
is this step necessary given that all the columns will be casted as 'object' in _get_combinations?
Contributor
Author
|
@sarahmish all should be addressed in the previous commit |
pvk-developer
approved these changes
Aug 17, 2026
sarahmish
approved these changes
Aug 18, 2026
nemanja-vujic
force-pushed
the
issue-2921-and-2920-overlaping-check
branch
2 times, most recently
from
August 18, 2026 16:12
f2607d6 to
cb8d703
Compare
…al and synthetic data
nemanja-vujic
force-pushed
the
issue-2921-and-2920-overlaping-check
branch
from
August 18, 2026 16:56
cb8d703 to
aac84db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add utils.py with two functions that measure how much the synthetic data reuses values from the real data.
get_combination_overlap counts combinations of column values that appear in both datasets
get_pii_overlap does the same for the values of a single PII column.
Resolves #2921
Resolves #2920