Repository navigation
Add key action support in multiple entry edit mode - #111
Merged
Merged
Conversation
Reworks PR #48 on the current dev branch. In multiple entry edit mode: - SetValue1 / SetValue2 now set the left / right border of the entry under the cursor to the cursor position. - Adds SetCurrentEntryLeft / SetCurrentEntryRight actions that set the left / right border of the current entry regardless of cursor position. The original PR plumbed a MutableState<Int> for the current index and hand-rolled the flattened point-index math (which was buggy). The dev branch already exposes `project` on MarkerState and centralizes the flattened-index scheme, so this reads the current index from `project.currentModule.currentIndex` and reuses the existing getDraggedEntries / border-index helpers. Single edit mode behavior is unchanged. Adds English/Chinese/Japanese/Korean strings and tests covering the new multi-edit resolution paths. Co-Authored-By: RibosomeK <122797zhyktb@gmail.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jul 10, 2026
sdercolin
added a commit
that referenced
this pull request
Jul 13, 2026
Reflects the features merged in #111 and #112 across all four READMEs (en/zh-CN/ja/ko): - Correct the parameter-line key action note: it is no longer limited to single entry editing mode. In multi-entry editing mode Q/W move the left/right border of the entry under the cursor, and the current-entry border actions can be bound in Keymaps. - Add the opt-in "Click to jump to entry" editor preference to the Multi-entry editing mode section. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworks #48 (by @RibosomeK) on the current
devbranch.What it does
In multiple entry edit mode:
SetValue1/SetValue2set the left / right border of the entry under the cursor to the cursor position.SetCurrentEntryLeft/SetCurrentEntryRightactions set the left / right border of the current entry, regardless of cursor position.Single entry edit mode behavior is unchanged.
How it differs from the original PR
The original PR plumbed a
MutableState<Int>for the current index (the author flagged that it couldn't read the newest value) and hand-rolled the flattened point-index math, which was incorrect for labelers where not all fields have shortcut indexes.Since then,
devhas refactored this area:MarkerStatenow holdsproject, so the current index is read directly fromproject.currentModule.currentIndex— the original bug disappears, no extra state plumbing.getDraggedEntries/ border-index helpers instead of duplicating the math.As a result the feature reduces to computing the correct flattened
pointIndexin multi-edit mode, then reusing the existing drag machinery.Notes
Tests
getStartBorderPointIndex/getEndBorderPointIndex(reused by the existinggetPointIndexAsSingleEntry).MarkerStateMiscTestcases for both borders, cursor-outside-any-entry, unsupportedSetValue3+in multi-edit, current-entry-vs-cursor divergence, and single-edit no-op for the new actions.ktlintCheck+ the marker / strings test suites pass.🤖 Generated with Claude Code