Add working-directory support - #5
Open
0x2b3bfa0 wants to merge 2 commits into
Open
Conversation
Owner
|
Closing and reopening to trigger CI. Sorry for the noise! |
scruplelesswizard
requested changes
Jul 30, 2026
scruplelesswizard
left a comment
Owner
There was a problem hiding this comment.
Useful feature for monorepo setups, but there are two bugs in the current diff that mean it doesn't actually work yet:
- The guard checks
${{ inputs.working.directory }}(dot) instead of${{ inputs.working-directory }}(hyphen, matching the input's actual name).inputs.working.directorydoesn't resolve to anything, so this condition is always false and thecdnever runs — the feature is currently dead code. - Even with #1 fixed,
split_testsis downloaded viacurlinto the job's original working directory in the install step. If this stepcds into a subdirectory first,./split_testson the next line won't resolve — the binary isn't there. You'd need an absolute path to the installed binary (e.g. capture$GITHUB_WORKSPACE/wherever it's installed before thecd, or invoke it via an absolute path) for this to work from a non-default working directory.
Fix the input reference and the binary path and this should be good to merge — happy to take another look once updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds
working-directorysupport, very useful for monorepo setups where paths have to be relative to a subdirectory.