fix sign of sph_bessel_k and sph_bessel_k_jac on arm - #246
Merged
Conversation
Member
Author
|
I can't tell why CI isn't running?? |
Member
|
GHA is having a bit of a moment I'm afraid |
Member
Author
|
Hmm seems I have not actually fixed the issue |
j-bowhay
marked this pull request as draft
August 7, 2026 07:01
j-bowhay
marked this pull request as ready for review
August 13, 2026 17:47
Member
Author
|
@lucascolley turns out I was just being stupid, this is ready to go |
lucascolley
self-requested a review
August 13, 2026 18:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue
closes #237
What does this implement/fix?
Hopefully fixes arm result by use real implementation when
zhas zero imaginary partAdditional information
AI Generation Disclosure
no ai