Skip to content

feat: Add in-place TTree branch addition and row extension #1690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yokubas wants to merge 49 commits into
base: main
Choose a base branch
from
+793 −7
Open

feat: Add in-place TTree branch addition and row extension #1690

Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
9e96466
Add in-place TTree branch addition
Yokubas Jul 27, 2026
81ce9b3
Add in-place TTree branch addition with tests
Yokubas Jul 27, 2026
3f89df6
Add in-place TTree branch addition with tests
Yokubas Jul 27, 2026
56fd418
Add in-place TTree extend method
Yokubas Jul 27, 2026
73d82ab
Add in-place TTree extend and add_branches with tests
Yokubas Jul 27, 2026
990acb0
style: pre-commit fixes
pre-commit-ci[bot] Jul 27, 2026
fbe47d8
Rename test file to test_1690_ttree_inplace.py
Yokubas Jul 27, 2026
f91e25a
Merge branch 'Yokubas/ttree-inplace-v2' of https://github.com/Yokubas…
Yokubas Jul 27, 2026
cdf5d21
style: pre-commit fixes
pre-commit-ci[bot] Jul 27, 2026
daab666
Move imports to top level in writable.py
Yokubas Jul 27, 2026
1a990e0
Merge branch 'Yokubas/ttree-inplace-v2' of https://github.com/Yokubas…
Yokubas Jul 27, 2026
cf5532a
Add accept_new_fields kwarg to extend
Yokubas Jul 27, 2026
b0e7d43
style: pre-commit fixes
pre-commit-ci[bot] Jul 27, 2026
1b303df
Fix extend for multiple sessions and add basket overflow check
Yokubas Jul 27, 2026
9ab366c
Merge branch 'Yokubas/ttree-inplace-v2' of https://github.com/Yokubas…
Yokubas Jul 27, 2026
314ee2f
style: pre-commit fixes
pre-commit-ci[bot] Jul 27, 2026
2a2983d
Use self._file instead of opening uproot.update again
Yokubas Jul 28, 2026
3537114
Merge branch 'Yokubas/ttree-inplace-v2' of https://github.com/Yokubas…
Yokubas Jul 28, 2026
cbb47aa
Fix hardcoded byte range for fBranches TObjArray bcnt search
Yokubas Jul 28, 2026
36429fe
Find TTree fEntries more reliably using unique sequence
Yokubas Jul 28, 2026
ba54114
style: pre-commit fixes
pre-commit-ci[bot] Jul 28, 2026
f012ece
Validate branch length matches tree in add_branches
Yokubas Jul 28, 2026
55f965d
Merge branch 'Yokubas/ttree-inplace-v2' of https://github.com/Yokubas…
Yokubas Jul 28, 2026
6373215
Clean up tests and enforce all branches in extend
Yokubas Jul 28, 2026
f97c03d
style: pre-commit fixes
pre-commit-ci[bot] Jul 28, 2026
314fe05
Fix fEND write size for big files (>2GB)
Yokubas Jul 28, 2026
b7c62d1
Merge branch 'Yokubas/ttree-inplace-v2' of https://github.com/Yokubas…
Yokubas Jul 28, 2026
f34b48c
Merge remote-tracking branch 'upstream/main' into Yokubas/ttree-inpla…
Yokubas Aug 3, 2026
3cb7b1d
Use cascade machinery for extend on existing TTrees
Yokubas Aug 3, 2026
d7ae561
style: pre-commit fixes
pre-commit-ci[bot] Aug 3, 2026
e4c8a04
Merge remote-tracking branch 'upstream/main' into Yokubas/ttree-inpla…
Yokubas Aug 5, 2026
af5ca84
Rewrite add_branches using cascade machinery
Yokubas Aug 5, 2026
7f0327b
Merge branch 'Yokubas/ttree-inplace-v2' of https://github.com/Yokubas…
Yokubas Aug 5, 2026
0fb41a2
Remove dead _extend_inplace code and fully use cascade machinery
Yokubas Aug 6, 2026
8b906e5
Fix metadata_start and basket_metadata_start computation in _load_exi…
Yokubas Aug 6, 2026
69c7a40
Restore accidentally deleted WritableTree properties
Yokubas Aug 7, 2026
49ca9ed
Fix extend validation to skip counter and record branches
Yokubas Aug 7, 2026
7aa10f2
Merge remote-tracking branch 'upstream/main' into Yokubas/ttree-inpla…
Yokubas Aug 7, 2026
04d8bf1
Fix extend validation to handle counter, record, and jagged branches
Yokubas Aug 7, 2026
c99184b
Merge remote-tracking branch 'upstream/main' into Yokubas/ttree-inpla…
Yokubas Aug 10, 2026
84d300f
Update test_writable_vs_readable_tree to reflect new behavior
Yokubas Aug 10, 2026
e5edb36
Use existing tree title in _load_existing_ttree instead of empty string
Yokubas Aug 10, 2026
64cb73e
Fix basket_metadata_start formula for trees with fMaxBaskets != 10
Yokubas Aug 10, 2026
495e10a
Add test for extend after many extends (fMaxBaskets > 10)
Yokubas Aug 10, 2026
3c0dc35
Replace BytesIO approach with sink.read + _ReadForUpdate pattern
Yokubas Aug 10, 2026
ae1f135
Use fIsRange to detect counter branches instead of name pattern matching
Yokubas Aug 12, 2026
85a4281
Use key.cycle instead of hardcoded cycle number 1 in _load_existing_t…
Yokubas Aug 12, 2026
d0f2b8e
Fix subdirectory support in add_branches and _load_existing_ttree
Yokubas Aug 12, 2026
d790b77
Fix counter branch validation in extend
Yokubas Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading