fix: distinguish duplicate CDecay statements - #613
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #613 +/- ##
==========================================
+ Coverage 97.60% 97.62% +0.02%
==========================================
Files 6 6
Lines 1209 1222 +13
==========================================
+ Hits 1180 1193 +13
Misses 29 29 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Hello @jpwgnr, thank you for the speedy action given our discussions. I will check more in detail as soon as possible. For now I wanted to make an annoying comment to keep some symmetry, which I like. Given that the hook is so new and only LHCb-via-you is using it for now, I think we can still afford a change of "order" in diagnostics to have the following table, which I find nicer - we can quickly release a patch version: | WDYT? |
|
Hello @jpwgnr, do let me know if you need help here, and I will try and make some time. I see that is now necessary for the LHCb work using the hook to be finalised and put into production. |
|
Hi @eduardo-rodrigues, |
eduardo-rodrigues
left a comment
There was a problem hiding this comment.
Super, all goods good to my eyes 👍!
Thank you. I will make a new patch release shortly so that you can go and use this in the LHCb validations.
|
Hello @GiacomoXT, this new hook, see the README, may be of use as well within Belle-II for your validations. Just thought I would drop a comment for you. Greetings. |
|
Thanks a lot! @vvsagar and I will impelement this in our pipeline. |
Top. Drop a line with feedback or a all-working-fine ... Thanks. |
Summary
This fixes two
CDecayvalidation issues discovered while enabling theDecayLanguage pre-commit hook in LHCb's DecFiles repository:
exposed files that define the same particle with both
DecayandCDecay.exposed repeated
CDecaystatements, which were not reported separately.DLW003is now nameddecay-cdecay-conflict, matching its existing meaning.The new
DLW006 duplicate-cdecaydiagnostic reports repeatedCDecaystatements, and the parser retains only one statement so it cannot create
duplicate charge-conjugate decay trees.
The warning categories, CLI output, tests, and documentation have been updated.
Validation
Let me know what you think @eduardo-rodrigues.