downgrade ring-defaults to be compatible with ring version#329
Merged
Conversation
ring/ring-defaults 0.7.0 is not compatible with ring/ring1.14.1, because it uses the content-length middleware, which has only been added to ring in v. 1.15.0 (see https://github.com/ring-clojure/ring/blob/master/CHANGELOG.md#1150-beta1-2025-07-22)
6 tasks
Member
|
Thanks, @holyjak! |
Member
|
@holyjak If I understand correctly, this is supposed to fix the problem you mentioned with Calva here: However, trying Clay after your change does not seem to fix the current Calva behaviour (where the inline Clay view is simply empty). I am wondering what else might be the problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
ring/ring-defaults 0.7.0 is not compatible with the ring/ring 1.14.1 that Clay claims to depend on, because it uses the content-length middleware, which has only been added to ring in v. 1.15.0 (see https://github.com/ring-clojure/ring/blob/master/CHANGELOG.md#1150-beta1-2025-07-22).
Fix:
Downgrade ring-defaults back to 0.6.0, before it added the wrap-content-length middleware.