Unify manual source URL test IDs in intake UI and E2E selectors#62
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
概要手動ソースURL入力コンポーネントのテスト識別子が標準化されます。テキストエリアと関連するフォーム要素が単数形の 変更内容手動ソースURL入力のテスト識別子
関連する可能性のあるPR
推定レビュー時間🎯 2 (Simple) | ⏱️ ~10 minutes 詩
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
data-testidvalues, so tests and documentation needed alignment.Description
src/features/landing/components/question-intake.tsxto set the textareadata-testidtomanual-source-url-inputand add a help text element withdata-testid="manual-source-url-help".MANUAL_SOURCE_URLS_ERROR_MESSAGEand added a conditionaldata-testid="manual-source-url-error"on the form error paragraph when the error equals the manual-URL validation message.e2e/home.spec.tsto assert visibility of the newmanual-source-url-inputtest id.specs/manual-source-url-intake.mdto document the newdata-testidvalues for input, help text, and validation error.Testing
pnpm typecheckwhich completed successfully.pnpm lintwhich completed successfully.Codex Task
Summary by CodeRabbit
リリースノート
Tests
Chores