Repository navigation
Make publication fixtures portable across macOS and Linux - #30
Merged
Merged
Conversation
sandover
marked this pull request as ready for review
October 14, 2026 23:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Homebrew publication fixture executes the real release-body workflow step. GNU-only
sed -imade that fixture fail on macOS. Write the filtered text to a temporary file and move it into place, preserving the rendered notes on both BSD and GNU systems.Start the fixture with indented notes and assert the exact unindented result. Run the existing fixture explicitly in the Linux, Intel macOS, and Apple Silicon PR packaging matrix, so this portability regression is caught before merge.
Validation: Linux publication/recovery fixtures, fresh full local
just check(exit 0), actionlint and whitespace checks passed. Initial CI on42a15e0passed every job, including publication fixtures on Linux and both macOS architectures. The current head additionally asserts the auth scenario reached the fake API and captured HTTP 403; fresh CI passed every applicable check on5538ae2.The auth fixture now checks both the exact fake API lookup in its trace and HTTP 403 in captured stderr, so a formatting failure before the API call cannot satisfy the expected-failure test.
The original main run also failed the Windows UDP CLI test with OS error 10054. It did not recur in either corrective CI run; this PR does not change UDP behavior or claim to resolve that separate concern.
Draft for direct review. No merge, release/tag publication, or live tap update.