Repository navigation
feat(cli): add experiment lifecycle trigger command - #379
Merged
Merged
Conversation
GhostofGoes
changed the title
GhostofGoes
force-pushed
the
feat-exp-trigger-lifecycle
branch
from
August 25, 2026 21:34
68359a5 to
939d657
Compare
GhostofGoes
marked this pull request as ready for review
August 25, 2026 21:35
GhostofGoes
force-pushed
the
feat-exp-trigger-lifecycle
branch
2 times, most recently
from
August 26, 2026 16:54
740edf8 to
870f7b2
Compare
Contributor
|
I like this idea, i know it would be nice to at least manually trigger the |
Contributor
Author
|
Addressed in ba3530f. Lifecycle triggers now persist a cleanup queue, and experiment stop runs cleanup for queued apps, including disabled apps. |
GhostofGoes
force-pushed
the
feat-exp-trigger-lifecycle
branch
from
September 1, 2026 01:05
ba3530f to
18fd766
Compare
GhostofGoes
marked this pull request as draft
September 1, 2026 01:05
nblair2
reviewed
Sep 2, 2026
GhostofGoes
force-pushed
the
feat-exp-trigger-lifecycle
branch
2 times, most recently
from
September 11, 2026 18:13
4a51cda to
0821d09
Compare
GhostofGoes
force-pushed
the
feat-exp-trigger-lifecycle
branch
3 times, most recently
from
September 15, 2026 22:03
c002ab6 to
76aec3b
Compare
Add phenix exp trigger for invoking configure, pre-start, post-start, running, or cleanup app lifecycles, including documented shorthands and validation. Deprecate trigger-running in favor of trigger running. Changes: - Add ParseAction(), Actions(), and Valid() functions for lifecycle stage parsing - Add Shorthand() method for action shorthand generation - Implement app filtering and cleanup queuing for triggered stages - Preserve app status during triggered pre-start (differs from normal deployment) - Queue cleanup for apps when other stages are triggered (pre-start, post-start, configure) - Implement phenix exp trigger command with lifecycle argument - Deprecate phenix exp trigger-running with migration path - Error when a triggered app isn't part of the experiment or the stage isn't applicable to it (e.g. triggering the running stage for a default app) - Restrict trigger command shell completion to apps applicable to the given experiment and lifecycle stage - Add comprehensive tests for filtering, cleanup queueing, failure handling, and the new app/stage validation - Document Trigger() function behavior and limitations - Update CHANGELOG with feature and deprecation notice Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
GhostofGoes
force-pushed
the
feat-exp-trigger-lifecycle
branch
from
September 15, 2026 23:35
76aec3b to
9a1530d
Compare
GhostofGoes
marked this pull request as ready for review
September 16, 2026 00:58
Contributor
Author
cmulk
pushed a commit
that referenced
this pull request
Sep 29, 2026
…running Document the `phenix exp trigger` command for manually invoking app lifecycle stages, compare `trigger configure` with `reconfigure`, and mark `trigger-running` as deprecated. Migrated from sandialabs/sceptre-phenix-docs#68. Refs: #379 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
phenix exp triggerfor invoking configure, pre-start, post-start, running, or cleanup app lifecycles, including documented shorthands and validation. Deprecatetrigger-runningin favor oftrigger running.Not sure if this is a feature we want to add, opening this PR to trigger discussion.
Documentation
See sceptre-phenix-docs#68 for comprehensive documentation of the new command.
Related Issue
N/A
Type of Change
Checklist
Additional Notes
Tested with triggering stages of various apps on a running experiment, plus Go tests.
Trigger examples
Tab completion