Repository navigation
fix(deps): raise Mako and requests floors past known advisories - #152
Open
adamsrnmsu wants to merge 1 commit into
Open
adamsrnmsu wants to merge 1 commit into
adamsrnmsu wants to merge 1 commit into
Conversation
This was referenced Oct 1, 2026
Author
|
@GhostofGoes i can't mark you as a reviewer for some reason |
Contributor
Welcome to the club of Phenix Contributors With No Real Power, we're a cool club. |
GhostofGoes
approved these changes
Oct 2, 2026
GhostofGoes
left a comment
GhostofGoes
left a comment
Contributor
There was a problem hiding this comment.
LTGM, assuming you've tested these with an actual deployment.
This was referenced Oct 2, 2026
Author
|
@GhostofGoes Thanks! Since we haven't cut a release yet, these are all technically just pre-release updates that can be verified in a real deployment before the release :) |
Contributor
|
Oh, there are releases for apps? |
Mako was held at ~=1.1.3 and requests pinned to 2.31.0, both below releases that fix published security advisories. Raise the floors to Mako>=1.3.10 and requests>=2.32.4. The full test suite passes against the new versions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016KAfcDUSerQCCWwBM9BxAo
adamsrnmsu
force-pushed
the
fix-deps-mako-requests
branch
from
October 4, 2026 23:53
cdec59d to
6c2d72f
Compare
GhostofGoes
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Raise two dependency floors that sit below releases fixing published security advisories:
Mako~=1.1.3→Mako>=1.3.10requests==2.31.0→requests>=2.32.4One of four independent PRs splitting up a hardening patch: #153 (pathlib refactor), #154 (path validation), #155 (command execution). Each is a single commit on
mainand they can merge in any order.Related Issues/PRs
#153, #154, #155. No dependencies between them.
Type of Change
chore)Checklist
Testing
make checkandmake testinsrc/pythonon Python 3.12, with Mako 1.4.3 and requests 2.34.2 installed: 697 passed.Additional Notes
The CHANGELOG entry goes at the top of
### Changed, so it doesn't conflict with the entries in the other PRs.🤖 Generated with Claude Code
https://claude.ai/code/session_016KAfcDUSerQCCWwBM9BxAo