Repository navigation
test(utils): replace obsolete router hostname fixture in cc locate tests - #148
Merged
Merged
Conversation
The cc locate tests modeled a router whose guest hostname phenix
lowercased and rewrote ("Site_A.RTR" reporting "site-a-rtr"). phenix no
longer rewrites router hostnames (sandialabs/sceptre-phenix#347), and
the topology schema rejects "_" and "." in hostnames, so that guest can
no longer exist.
A guest hostname can still differ from the minimega VM name, for example
on a Windows VM that the startup app has not yet renamed. Use that case
so the tests keep checking that lookup goes through the VM UUID.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two
mm_cc_client_locatetests modeled a router whose guest hostname phenix lowercased and rewrote (VMSite_A.RTRreportingsite-a-rtr). phenix no longer rewrites router hostnames (sandialabs/sceptre-phenix#347), and the topology schema rejects_and.in hostnames, so that guest can't exist anymore.A guest hostname can still differ from the minimega VM name. One example is a Windows VM that the startup app hasn't renamed yet. The tests now use that case, so they still check that lookup goes through the VM UUID. Test-only change.
Related Issues/PRs
Type of Change
fix)feat)docs)refactor)chore)test)Checklist
Testing
In
src/python:ruff check,ruff format --check,codespell,vulture, andpytest(697 passed).🤖 Generated with Claude Code