Skip to content

refactor: Split the logic from configure IPs to enable future extensability of the configure_ips.sh VMR - #8

Open
sdelliot wants to merge 5 commits into
sandialabs:mainfrom
sdelliot:refactor-configure-ips
Open

sdelliot wants to merge 5 commits into
sandialabs:mainfrom
sdelliot:refactor-configure-ips

Conversation

@sdelliot

Copy link
Copy Markdown
Collaborator

This PR breaks apart the logic from creating the input to the configure_ips.sh so that it can be overridden by future model components that may be linux based, but use a different VMR for setting the IP address.

@github-actions github-actions Bot added the refactor A code change that neither fixes a bug nor adds a feature label Jul 29, 2026
Comment thread src/firewheel_repo_linux/linux/model_component_objects.py Outdated
Comment thread src/firewheel_repo_linux/linux/model_component_objects.py Outdated
Co-authored-by: Steven Elliott <6461548+sdelliot@users.noreply.github.com>
gregjacobus
gregjacobus previously approved these changes Oct 5, 2026
@sdelliot
sdelliot force-pushed the refactor-configure-ips branch from 91b4186 to b5083ce Compare October 5, 2026 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor A code change that neither fixes a bug nor adds a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants