Skip to content

chore: sync node/pnpm versions across mise, package.json, and workflows #2223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
s-hirano-ist merged 3 commits into from
Apr 19, 2026
Merged

chore: sync node/pnpm versions across mise, package.json, and workflows #2223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d38cb5
chore: sync node/pnpm versions across mise, package.json, and workflows
claude Apr 19, 2026
046b869
chore: use .tool-versions for node/pnpm instead of .mise.toml
claude Apr 19, 2026
8c40f66
chore: switch node source to .nvmrc for cloudflare compat
claude Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .github/renovate.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
'github-actions',
'docker-compose',
'mise',
'nvm',
],
dependencyDashboard: true,
branchConcurrentLimit: 3,
Expand Down Expand Up @@ -77,6 +78,20 @@
groupSlug: 'mise',
minimumReleaseAge: '2 days',
},
{
matchDepNames: [
'node',
'pnpm',
],
matchManagers: [
'mise',
'npm',
'nvm',
],
groupName: 'node and pnpm',
groupSlug: 'node-pnpm',
minimumReleaseAge: '2 days',
},
{
matchManagers: [
'docker-compose',
Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
- name: Install Node.js
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6
with:
node-version: "24.14.1"
node-version-file: ".nvmrc"
cache: pnpm
cache-dependency-path: pnpm-lock.yaml

Expand Down Expand Up @@ -80,7 +80,7 @@ jobs:
- name: Install Node.js
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6
with:
node-version: "24.14.1"
node-version-file: ".nvmrc"
cache: pnpm
cache-dependency-path: pnpm-lock.yaml

Expand Down Expand Up @@ -109,7 +109,7 @@ jobs:
- name: Install Node.js
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6
with:
node-version: "24.14.1"
node-version-file: ".nvmrc"
cache: pnpm
cache-dependency-path: pnpm-lock.yaml

Expand Down Expand Up @@ -140,7 +140,7 @@ jobs:
- name: Install Node.js
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6
with:
node-version: "24.14.1"
node-version-file: ".nvmrc"
cache: pnpm
cache-dependency-path: pnpm-lock.yaml

Expand Down Expand Up @@ -169,7 +169,7 @@ jobs:
- name: Install Node.js
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6
with:
node-version: "24.14.1"
node-version-file: ".nvmrc"
cache: pnpm
cache-dependency-path: pnpm-lock.yaml

Expand Down Expand Up @@ -231,7 +231,7 @@ jobs:
- name: Install Node.js
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6
with:
node-version: "24.14.1"
node-version-file: ".nvmrc"
cache: pnpm
cache-dependency-path: pnpm-lock.yaml

Expand Down Expand Up @@ -261,7 +261,7 @@ jobs:
- name: Install Node.js
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6
with:
node-version: "24.14.1"
node-version-file: ".nvmrc"
cache: pnpm
cache-dependency-path: pnpm-lock.yaml

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
- name: Install Node.js
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6
with:
node-version: "24.14.1"
node-version-file: ".nvmrc"
cache: pnpm
cache-dependency-path: pnpm-lock.yaml

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/jscpd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
- name: Install Node.js
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6
with:
node-version: "24.14.1"
node-version-file: ".nvmrc"
cache: pnpm
cache-dependency-path: pnpm-lock.yaml
Comment on lines 23 to 28

@coderabbitai coderabbitai Bot Apr 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== .mise.toml =="
sed -n '1,40p' .mise.toml

echo "== actions/setup-node README: node-version-file examples =="
curl -fsSL https://raw.githubusercontent.com/actions/setup-node/v6/README.md \
  | sed -n '/node-version-file/,+4p'

echo "== actions/setup-node parser implementation =="
curl -fsSL https://raw.githubusercontent.com/actions/setup-node/v6/src/util.ts \
  | tr ';' '\n' \
  | sed -n '/getNodeVersionFromFile/,/printEnvDetailsAndSetOutput/p'

Repository: s-hirano-ist/s-private

Length of output: 3262

.mise.toml は setup-node の node-version-file として直接読めません。

actions/setup-node@v6 の parser は .mise.toml の node = "24.15.0" 形式に対応していません。パーサーの実装では:

  1. JSON として解析を試みる（失敗）
  2. 正規表現 /^(?:node(js)?\s+)?v?(?<version>[^\s]+)$/m でテキスト解析を試みる

この正規表現は node 24.15.0 のような形式を期待していますが、.mise.toml の node = "24.15.0" はマッチしません（= と引用符の存在）。その結果、パーサーはファイル全体を版文字列として返し、workflow は失敗します。

修正案: `.mise.toml` から Node バージョンを抽出して渡す 
+      - name: Read Node.js version from .mise.toml
+        id: node-version
+        shell: bash
+        run: |
+          node_version="$(grep '^node = ' .mise.toml | cut -d'"' -f2)"
+          test -n "$node_version"
+          echo "version=$node_version" >> "$GITHUB_OUTPUT"
+
       - name: Install Node.js
         uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6
         with:
-          node-version-file: ".mise.toml"
+          node-version: ${{ steps.node-version.outputs.version }}
           cache: pnpm
           cache-dependency-path: pnpm-lock.yaml
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- name: Install Node.js
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6
with:
node-version: "24.14.1"
node-version-file: ".mise.toml"
cache: pnpm
cache-dependency-path: pnpm-lock.yaml
- name: Read Node.js version from .mise.toml
id: node-version
shell: bash
run: |
node_version="$(grep '^node = ' .mise.toml | cut -d'"' -f2)"
test -n "$node_version"
echo "version=$node_version" >> "$GITHUB_OUTPUT"
- name: Install Node.js
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6
with:
node-version: ${{ steps.node-version.outputs.version }}
cache: pnpm
cache-dependency-path: pnpm-lock.yaml
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/jscpd.yaml around lines 23 - 28, The workflow currently
passes .mise.toml into actions/setup-node via node-version-file which the
action's parser can't read; replace that by adding a step (e.g., id:
extract-node-version) that reads .mise.toml and extracts the version with a
simple shell regex (example: grep -Po 'node\s*=\s*"\K[^"]+' .mise.toml) and
writes it to $GITHUB_OUTPUT as node_version, then update the actions/setup-node
step (the "Install Node.js" step using actions/setup-node@53b8394) to remove
node-version-file and instead use with: node-version: ${{
steps.extract-node-version.outputs.node_version }} (keep cache and
cache-dependency-path as-is).


Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/license-check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- name: Install Node.js
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6
with:
node-version: "24.14.1"
node-version-file: ".nvmrc"
cache: pnpm
cache-dependency-path: pnpm-lock.yaml

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/memlab.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- name: Install Node.js
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6
with:
node-version: "24.14.1"
node-version-file: ".nvmrc"
cache: pnpm
cache-dependency-path: pnpm-lock.yaml

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/mutation-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
- name: Install Node.js
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6
with:
node-version: "24.14.1"
node-version-file: ".nvmrc"
cache: pnpm
cache-dependency-path: pnpm-lock.yaml

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/prisma-deploy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
- name: Install Node.js
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6
with:
node-version: "24.14.1"
node-version-file: ".nvmrc"
cache: pnpm
cache-dependency-path: pnpm-lock.yaml

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-please.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:

- uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6
with:
node-version: 24.14.1
node-version-file: ".nvmrc"
registry-url: "https://registry.npmjs.org"
Comment thread
coderabbitai[bot] marked this conversation as resolved.

- name: Install dependencies
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update-reports.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- name: Install Node.js
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6
with:
node-version: "24.14.1"
node-version-file: ".nvmrc"

- name: Install pnpm
uses: pnpm/action-setup@08c4be7e2e672a47d11bd04269e27e5f3e8529cb # v6
Expand Down
4 changes: 3 additions & 1 deletion .mise.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
[settings]
idiomatic_version_file_enable_tools = ["node"]

[env]
_.file = ".env.local"

[tools]
node = "24.15.0"
pnpm = "10.33.0"
doppler = { version = "3.75.3", exe = "doppler" }
"npm:agent-browser" = "0.26.0"
1 change: 1 addition & 0 deletions .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
24.15.0
3 changes: 3 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
"author": "s-hirano-ist",
"description": "Private pages and admin tools for s-hirano-ist.",
"packageManager": "pnpm@10.33.0",
"engines": {
"node": "24.x"
},
"type": "module",
"scripts": {
"dev": "pnpm --recursive --parallel --stream dev",
Expand Down
Loading