Remove generic From conversions#254
Open
demurgos wants to merge 1 commit into
Open
Conversation
This commit removes generic `From` conversions. Generic conversions are a source of non-local errors caused by ambiguous trait resolution. It is better to ask users to provide more context rather than implementing generic conversions. Note that this issue does not apply to regular constructors. The `Cookie::new` method can remain generic without problems. This commit adds implementations for all pairs of `&str`, `Cow<'_, str>`, and `String` for `Cookie`. This mirrors the implementations for name-only construction. For `Expiration`, conversions are provided for `Option<OffsetDateTime>` and `OffsetDateTime`. Closes rwf2#251
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes generic
Fromconversions. Generic conversions are a source of non-local errors caused by ambiguous trait resolution. It is better to ask users to provide more context rather than implementing generic conversions.Note that this issue does not apply to regular constructors. The
Cookie::newmethod can remain generic without problems.This commit adds implementations for all pairs of
&str,Cow<'_, str>, andStringforCookie. This mirrors the implementations for name-only construction.For
Expiration, conversions are provided forOption<OffsetDateTime>andOffsetDateTime.Closes #251