Skip to content

Only try once to add the view changes since link#2452

Merged
Urgau merged 1 commit into
rust-lang:masterfrom
Urgau:gh-changes-since-no-retry
Jul 6, 2026
Merged

Only try once to add the view changes since link#2452
Urgau merged 1 commit into
rust-lang:masterfrom
Urgau:gh-changes-since-no-retry

Conversation

@Urgau

@Urgau Urgau commented Jul 6, 2026

Copy link
Copy Markdown
Member

Only try to add the view changes since link once to avoid retrying multiple times for comments that may have been deleted, or review comments we can't modify, ...

@Urgau Urgau requested a review from Kobzol July 6, 2026 17:06

@Kobzol Kobzol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were the jobs repeated many times? 🥶 Good catch!

View changes since this review

@Urgau

Urgau commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

Were the jobs repeated many times?

I don't know, I think they repeated indefinitely, but it's hard to tell.

triagebot/src/db/jobs.rs

Lines 95 to 97 in 8fe35ac

// Selects all jobs with:
// - scheduled_at in the past
// - error_message is null or executed_at is at least 60 minutes ago (intended to make repeat executions rare enough)

@Urgau Urgau added this pull request to the merge queue Jul 6, 2026
Merged via the queue into rust-lang:master with commit f79af24 Jul 6, 2026
3 checks passed
@Urgau Urgau deleted the gh-changes-since-no-retry branch July 6, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants