Skip to content

Tell the user that nothing changed rather than a cryptic GitHub message #2446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Urgau merged 1 commit into from
Jun 29, 2026
+15 −1
Merged

Tell the user that nothing changed rather than a cryptic GitHub message #2446

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/gh_changes_since.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ use std::sync::Arc;
use anyhow::Context as _;
use axum::{
extract::{Path, State},
response::{IntoResponse, Redirect, Response},
response::{Html, IntoResponse, Redirect, Response},
};
use hyper::StatusCode;

Expand Down Expand Up @@ -47,6 +47,20 @@ pub async fn gh_changes_since(
let newbase = &pr.base.as_ref().context("no base")?.sha;
let newhead = &pr.head.as_ref().context("no head")?.sha;

// Did something changed, no?
if oldhead == newhead {
// Inform the user that nothing changed.
return Ok((StatusCode::OK, Html(format!(
r##"<!DOCTYPE html>
<title>Changes since for {owner}/{repo}#{pr_num}</title>
<style>
:root {{ color-scheme: light dark; font-family: system-ui; margin: 2rem auto; max-width: 60ch; }}
</style>
<h1>No changes since this review.</h1>
<p>Head back to the <a href="https://github.com/{owner}/{repo}/pull/{pr_num}/changes">latest changes here</a>.</p>
"##))).into_response());
}

// Has the base changed?
if oldbase == newbase {
// No, try finding if only new commits have been added by trying to finding the oldhead between oldbase..newhead
Expand Down