implement formatting for super let#6952
Merged
ytmimi merged 1 commit intoJun 26, 2026
Merged
Conversation
rustbot
added
the
S-waiting-on-review
Contributor
|
Honestly, I didn't know super let was a thing. Is it stable? |
Contributor
Author
|
no, its unstable |
Contributor
|
Can you link me to the tracking issue? |
Contributor
Author
ytmimi
reviewed
Jun 26, 2026
Comment on lines
+68
to
+69
| let super_ = self.super_.is_some(); | ||
| let let_ = if super_ { "super let " } else { "let " }; |
Contributor
There was a problem hiding this comment.
not something we need to resolve now, but if the user wrote super /* comment */ let, then this reformatting would completely remove the comment. Might be worth adding a FIXME comment for the potential comment loss.
ytmimi
reviewed
Jun 26, 2026
Contributor
There was a problem hiding this comment.
Let's add a #![feature(super_let)] annotation here so that it's easier for us to tell that this is for an unstable feature.
Contributor
|
@rustbot author |
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
bend-n
force-pushed
the
implement_formatting_4_super_let_items
branch
from
a6fad3d to
a42a04e
Compare
bend-n
force-pushed
the
implement_formatting_4_super_let_items
branch
from
a42a04e to
61217c5
Compare
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
ytmimi
approved these changes
Jun 26, 2026
rustbot
added
release-notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hi, i was just hoping to have my super lets format. hope this looks good!