[perf] move attrs out of rustc_hir by mejrs · Pull Request #159870 · rust-lang/rust

mejrs · 2026-07-24T22:11:01Z

mejrs · 2026-07-24T22:11:19Z

[perf] move attrs out of rustc_hir

rust-bors · 2026-07-25T00:15:59Z

☀️ Try build successful (CI)
Build commit: 5bfd159 (5bfd1598fde1f19d34aa3199461963dcce69bb0a)
Base parent: 29e68fe (29e68fe2295f8fc2feb52b8cb0b61a055842fdcf)

rust-timer · 2026-07-25T01:04:53Z

Finished benchmarking commit (5bfd159): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (secondary 5.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.1%	[5.1%, 5.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary 2.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.8%	[2.7%, 2.9%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 488.104s -> 488.889s (0.16%)
Artifact size: 387.69 MiB -> 387.68 MiB (-0.00%)

rust-log-analyzer · 2026-07-25T09:30:05Z

The job aarch64-gnu-llvm-21-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-gnu-gcc": No such file or directory (os error 2)
cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-gnu-g++": No such file or directory (os error 2)
cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-gnu-g++": No such file or directory (os error 2)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Snapshot Summary ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Snapshot file: src/bootstrap/src/core/builder/cli_paths/snapshots/x_bench.snap
Snapshot: x_bench
Source: src/bootstrap/src/core/builder/cli_paths/tests.rs:66
────────────────────────────────────────────────────────────────────────────────
Expression: bench
────────────────────────────────────────────────────────────────────────────────
-old snapshot
+new results
────────────┬───────────────────────────────────────────────────────────────────
   24    24 │     - Set({bench::compiler/rustc_ast_ir})
   25    25 │     - Set({bench::compiler/rustc_ast_lowering})
   26    26 │     - Set({bench::compiler/rustc_ast_passes})
   27    27 │     - Set({bench::compiler/rustc_ast_pretty})
         28 │+    - Set({bench::compiler/rustc_attr_ir})
   28    29 │     - Set({bench::compiler/rustc_attr_parsing})
   29    30 │     - Set({bench::compiler/rustc_baked_icu_data})
   30    31 │     - Set({bench::compiler/rustc_borrowck})
   31    32 │     - Set({bench::compiler/rustc_builtin_macros})
────────────┴───────────────────────────────────────────────────────────────────
Stopped on the first failure. Run `cargo insta test` to run all snapshots.

thread 'core::builder::cli_paths::tests::x_bench' (2973) panicked at /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/insta-1.47.2/src/runtime.rs:719:13:
snapshot assertion for 'x_bench' failed in line 66
---- core::builder::cli_paths::tests::x_bench stdout end ----
---- core::builder::cli_paths::tests::x_build_compiler stdout ----
Running test in /tmp/.tmplUrpFb
cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-gnu-gcc": No such file or directory (os error 2)
cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-gnu-g++": No such file or directory (os error 2)
cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-gnu-g++": No such file or directory (os error 2)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Snapshot Summary ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Snapshot file: src/bootstrap/src/core/builder/cli_paths/snapshots/x_build_compiler.snap
Snapshot: x_build_compiler
Source: src/bootstrap/src/core/builder/cli_paths/tests.rs:66
────────────────────────────────────────────────────────────────────────────────
Expression: build compiler
────────────────────────────────────────────────────────────────────────────────
-old snapshot
+new results
────────────┬───────────────────────────────────────────────────────────────────
    6     6 │     - Set({build::compiler/rustc_ast_ir})
    7     7 │     - Set({build::compiler/rustc_ast_lowering})
    8     8 │     - Set({build::compiler/rustc_ast_passes})
    9     9 │     - Set({build::compiler/rustc_ast_pretty})
         10 │+    - Set({build::compiler/rustc_attr_ir})
   10    11 │     - Set({build::compiler/rustc_attr_parsing})
   11    12 │     - Set({build::compiler/rustc_baked_icu_data})
   12    13 │     - Set({build::compiler/rustc_borrowck})
   13    14 │     - Set({build::compiler/rustc_builtin_macros})
────────────┴───────────────────────────────────────────────────────────────────
Stopped on the first failure. Run `cargo insta test` to run all snapshots.

thread 'core::builder::cli_paths::tests::x_build_compiler' (2975) panicked at /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/insta-1.47.2/src/runtime.rs:719:13:
snapshot assertion for 'x_build_compiler' failed in line 66
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
---- core::builder::cli_paths::tests::x_build_compiler stdout end ----
---- core::builder::cli_paths::tests::x_check stdout ----
Running test in /tmp/.tmp02ZqQ9
cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-gnu-gcc": No such file or directory (os error 2)
cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-gnu-g++": No such file or directory (os error 2)
cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-gnu-g++": No such file or directory (os error 2)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Snapshot Summary ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Snapshot file: src/bootstrap/src/core/builder/cli_paths/snapshots/x_check.snap
Snapshot: x_check
Source: src/bootstrap/src/core/builder/cli_paths/tests.rs:66
────────────────────────────────────────────────────────────────────────────────
Expression: check
────────────────────────────────────────────────────────────────────────────────
-old snapshot
+new results
────────────┬───────────────────────────────────────────────────────────────────
    8     8 │     - Set({check::compiler/rustc_ast_ir})
    9     9 │     - Set({check::compiler/rustc_ast_lowering})
   10    10 │     - Set({check::compiler/rustc_ast_passes})
   11    11 │     - Set({check::compiler/rustc_ast_pretty})
         12 │+    - Set({check::compiler/rustc_attr_ir})
   12    13 │     - Set({check::compiler/rustc_attr_parsing})
   13    14 │     - Set({check::compiler/rustc_baked_icu_data})
   14    15 │     - Set({check::compiler/rustc_borrowck})
   15    16 │     - Set({check::compiler/rustc_builtin_macros})
────────────┴───────────────────────────────────────────────────────────────────
Stopped on the first failure. Run `cargo insta test` to run all snapshots.

thread 'core::builder::cli_paths::tests::x_check' (3311) panicked at /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/insta-1.47.2/src/runtime.rs:719:13:
snapshot assertion for 'x_check' failed in line 66
---- core::builder::cli_paths::tests::x_check stdout end ----
---- core::builder::cli_paths::tests::x_check_compiler stdout ----
Running test in /tmp/.tmpVA7YD6
cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-gnu-gcc": No such file or directory (os error 2)
cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-gnu-g++": No such file or directory (os error 2)
cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-gnu-g++": No such file or directory (os error 2)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Snapshot Summary ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Snapshot file: src/bootstrap/src/core/builder/cli_paths/snapshots/x_check_compiler.snap
Snapshot: x_check_compiler
Source: src/bootstrap/src/core/builder/cli_paths/tests.rs:66
────────────────────────────────────────────────────────────────────────────────
Expression: check compiler
────────────────────────────────────────────────────────────────────────────────
-old snapshot
+new results
────────────┬───────────────────────────────────────────────────────────────────
    8     8 │     - Set({check::compiler/rustc_ast_ir})
    9     9 │     - Set({check::compiler/rustc_ast_lowering})
   10    10 │     - Set({check::compiler/rustc_ast_passes})
   11    11 │     - Set({check::compiler/rustc_ast_pretty})
         12 │+    - Set({check::compiler/rustc_attr_ir})
   12    13 │     - Set({check::compiler/rustc_attr_parsing})
   13    14 │     - Set({check::compiler/rustc_baked_icu_data})
   14    15 │     - Set({check::compiler/rustc_borrowck})
   15    16 │     - Set({check::compiler/rustc_builtin_macros})
────────────┴───────────────────────────────────────────────────────────────────
Stopped on the first failure. Run `cargo insta test` to run all snapshots.

thread 'core::builder::cli_paths::tests::x_check_compiler' (3467) panicked at /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/insta-1.47.2/src/runtime.rs:719:13:
snapshot assertion for 'x_check_compiler' failed in line 66
---- core::builder::cli_paths::tests::x_check_compiler stdout end ----
---- core::builder::cli_paths::tests::x_check_compiletest_include_default_paths stdout ----
Running test in /tmp/.tmp0kKabJ
cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-gnu-gcc": No such file or directory (os error 2)
cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-gnu-g++": No such file or directory (os error 2)
cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-gnu-g++": No such file or directory (os error 2)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Snapshot Summary ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Snapshot file: src/bootstrap/src/core/builder/cli_paths/snapshots/x_check_compiletest_include_default_paths.snap
Snapshot: x_check_compiletest_include_default_paths
Source: src/bootstrap/src/core/builder/cli_paths/tests.rs:66
────────────────────────────────────────────────────────────────────────────────
Expression: check compiletest --include-default-paths
────────────────────────────────────────────────────────────────────────────────
-old snapshot
+new results
────────────┬───────────────────────────────────────────────────────────────────
    8     8 │     - Set({check::compiler/rustc_ast_ir})
    9     9 │     - Set({check::compiler/rustc_ast_lowering})
   10    10 │     - Set({check::compiler/rustc_ast_passes})
   11    11 │     - Set({check::compiler/rustc_ast_pretty})
         12 │+    - Set({check::compiler/rustc_attr_ir})
   12    13 │     - Set({check::compiler/rustc_attr_parsing})
   13    14 │     - Set({check::compiler/rustc_baked_icu_data})
   14    15 │     - Set({check::compiler/rustc_borrowck})
   15    16 │     - Set({check::compiler/rustc_builtin_macros})
────────────┴───────────────────────────────────────────────────────────────────
Stopped on the first failure. Run `cargo insta test` to run all snapshots.

thread 'core::builder::cli_paths::tests::x_check_compiletest_include_default_paths' (3469) panicked at /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/insta-1.47.2/src/runtime.rs:719:13:
snapshot assertion for 'x_check_compiletest_include_default_paths' failed in line 66
---- core::builder::cli_paths::tests::x_check_compiletest_include_default_paths stdout end ----
---- core::builder::cli_paths::tests::x_clippy stdout ----
Running test in /tmp/.tmpcFmgHl
cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-gnu-gcc": No such file or directory (os error 2)
cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-gnu-g++": No such file or directory (os error 2)
cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-gnu-g++": No such file or directory (os error 2)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Snapshot Summary ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Snapshot file: src/bootstrap/src/core/builder/cli_paths/snapshots/x_clippy.snap
Snapshot: x_clippy
Source: src/bootstrap/src/core/builder/cli_paths/tests.rs:66
────────────────────────────────────────────────────────────────────────────────
Expression: clippy
────────────────────────────────────────────────────────────────────────────────
-old snapshot
+new results
────────────┬───────────────────────────────────────────────────────────────────
   23    23 │     - Set({clippy::compiler/rustc_ast_ir})
   24    24 │     - Set({clippy::compiler/rustc_ast_lowering})
   25    25 │     - Set({clippy::compiler/rustc_ast_passes})
   26    26 │     - Set({clippy::compiler/rustc_ast_pretty})
         27 │+    - Set({clippy::compiler/rustc_attr_ir})
   27    28 │     - Set({clippy::compiler/rustc_attr_parsing})
   28    29 │     - Set({clippy::compiler/rustc_baked_icu_data})
   29    30 │     - Set({clippy::compiler/rustc_borrowck})
   30    31 │     - Set({clippy::compiler/rustc_builtin_macros})
────────────┴───────────────────────────────────────────────────────────────────
Stopped on the first failure. Run `cargo insta test` to run all snapshots.

thread 'core::builder::cli_paths::tests::x_clippy' (3639) panicked at /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/insta-1.47.2/src/runtime.rs:719:13:
snapshot assertion for 'x_clippy' failed in line 66
---- core::builder::cli_paths::tests::x_clippy stdout end ----
---- core::builder::cli_paths::tests::x_fix stdout ----
Running test in /tmp/.tmpDsQr0O
WARNING: `x fix` is provided on a best-effort basis and does not support all `cargo fix` options correctly.
cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-gnu-gcc": No such file or directory (os error 2)
cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-gnu-g++": No such file or directory (os error 2)
cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-gnu-g++": No such file or directory (os error 2)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Snapshot Summary ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Snapshot file: src/bootstrap/src/core/builder/cli_paths/snapshots/x_fix.snap
Snapshot: x_fix
Source: src/bootstrap/src/core/builder/cli_paths/tests.rs:66
────────────────────────────────────────────────────────────────────────────────
Expression: fix
────────────────────────────────────────────────────────────────────────────────
-old snapshot
+new results
────────────┬───────────────────────────────────────────────────────────────────
    8     8 │     - Set({fix::compiler/rustc_ast_ir})
    9     9 │     - Set({fix::compiler/rustc_ast_lowering})
   10    10 │     - Set({fix::compiler/rustc_ast_passes})
   11    11 │     - Set({fix::compiler/rustc_ast_pretty})
         12 │+    - Set({fix::compiler/rustc_attr_ir})
   12    13 │     - Set({fix::compiler/rustc_attr_parsing})
   13    14 │     - Set({fix::compiler/rustc_baked_icu_data})
   14    15 │     - Set({fix::compiler/rustc_borrowck})
   15    16 │     - Set({fix::compiler/rustc_builtin_macros})
────────────┴───────────────────────────────────────────────────────────────────
Stopped on the first failure. Run `cargo insta test` to run all snapshots.

thread 'core::builder::cli_paths::tests::x_fix' (3800) panicked at /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/insta-1.47.2/src/runtime.rs:719:13:
snapshot assertion for 'x_fix' failed in line 66
---- core::builder::cli_paths::tests::x_fix stdout end ----
---- core::builder::cli_paths::tests::x_test stdout ----
Running test in /tmp/.tmpN1NCwA
cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-gnu-gcc": No such file or directory (os error 2)
cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-gnu-g++": No such file or directory (os error 2)
cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-gnu-g++": No such file or directory (os error 2)
---
   79    80 │     - Set({test::compiler/rustc_builtin_macros})
────────────┴───────────────────────────────────────────────────────────────────
Stopped on the first failure. Run `cargo insta test` to run all snapshots.

thread 'core::builder::cli_paths::tests::x_test' (4103) panicked at /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/insta-1.47.2/src/runtime.rs:719:13:
snapshot assertion for 'x_test' failed in line 66
---- core::builder::cli_paths::tests::x_test stdout end ----
---- core::builder::cli_paths::tests::x_test_skip_coverage stdout ----
Running test in /tmp/.tmpJuyeD4
cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-gnu-gcc": No such file or directory (os error 2)
cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-gnu-g++": No such file or directory (os error 2)
cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-gnu-g++": No such file or directory (os error 2)
Skipping Suite(test::tests/coverage) because it is excluded
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Snapshot Summary ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Snapshot file: src/bootstrap/src/core/builder/cli_paths/snapshots/x_test_skip_coverage.snap
Snapshot: x_test_skip_coverage
Source: src/bootstrap/src/core/builder/cli_paths/tests.rs:66
────────────────────────────────────────────────────────────────────────────────
Expression: test --skip=coverage
────────────────────────────────────────────────────────────────────────────────
-old snapshot
+new results
---
   76    77 │     - Set({test::compiler/rustc_builtin_macros})
────────────┴───────────────────────────────────────────────────────────────────
Stopped on the first failure. Run `cargo insta test` to run all snapshots.

thread 'core::builder::cli_paths::tests::x_test_skip_coverage' (4611) panicked at /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/insta-1.47.2/src/runtime.rs:719:13:
snapshot assertion for 'x_test_skip_coverage' failed in line 66
---- core::builder::cli_paths::tests::x_test_skip_coverage stdout end ----
---- core::builder::cli_paths::tests::x_test_skip_coverage_map stdout ----
Running test in /tmp/.tmpevvAFy
cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-gnu-gcc": No such file or directory (os error 2)
cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-gnu-g++": No such file or directory (os error 2)
cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-gnu-g++": No such file or directory (os error 2)
---
   79    80 │     - Set({test::compiler/rustc_builtin_macros})
────────────┴───────────────────────────────────────────────────────────────────
Stopped on the first failure. Run `cargo insta test` to run all snapshots.

thread 'core::builder::cli_paths::tests::x_test_skip_coverage_map' (4634) panicked at /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/insta-1.47.2/src/runtime.rs:719:13:
snapshot assertion for 'x_test_skip_coverage_map' failed in line 66
---- core::builder::cli_paths::tests::x_test_skip_coverage_map stdout end ----
---- core::builder::cli_paths::tests::x_test_skip_coverage_run stdout ----
Running test in /tmp/.tmp1KiURJ
cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-gnu-gcc": No such file or directory (os error 2)
cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-gnu-g++": No such file or directory (os error 2)
cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-gnu-g++": No such file or directory (os error 2)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Snapshot Summary ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Snapshot file: src/bootstrap/src/core/builder/cli_paths/snapshots/x_test_skip_coverage_run.snap
Snapshot: x_test_skip_coverage_run
Source: src/bootstrap/src/core/builder/cli_paths/tests.rs:66
────────────────────────────────────────────────────────────────────────────────
Expression: test --skip=coverage-run
────────────────────────────────────────────────────────────────────────────────
-old snapshot
+new results
---
   79    80 │     - Set({test::compiler/rustc_builtin_macros})
────────────┴───────────────────────────────────────────────────────────────────
Stopped on the first failure. Run `cargo insta test` to run all snapshots.

thread 'core::builder::cli_paths::tests::x_test_skip_coverage_run' (4637) panicked at /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/insta-1.47.2/src/runtime.rs:719:13:
snapshot assertion for 'x_test_skip_coverage_run' failed in line 66
---- core::builder::cli_paths::tests::x_test_skip_coverage_run stdout end ----
---- core::builder::cli_paths::tests::x_test_skip_tests stdout ----
Running test in /tmp/.tmpedIqXz
cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-gnu-gcc": No such file or directory (os error 2)
cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-gnu-g++": No such file or directory (os error 2)
cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-gnu-g++": No such file or directory (os error 2)
---
Skipping Suite(test::tests/rustdoc-json) because it is excluded
Skipping Suite(test::tests/run-make) because it is excluded
Skipping Suite(test::tests/run-make-cargo) because it is excluded
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Snapshot Summary ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Snapshot file: src/bootstrap/src/core/builder/cli_paths/snapshots/x_test_skip_tests.snap
Snapshot: x_test_skip_tests
Source: src/bootstrap/src/core/builder/cli_paths/tests.rs:66
────────────────────────────────────────────────────────────────────────────────
Expression: test --skip=tests
────────────────────────────────────────────────────────────────────────────────
-old snapshot
+new results
---
   40    41 │     - Set({test::compiler/rustc_builtin_macros})
────────────┴───────────────────────────────────────────────────────────────────
Stopped on the first failure. Run `cargo insta test` to run all snapshots.

thread 'core::builder::cli_paths::tests::x_test_skip_tests' (4651) panicked at /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/insta-1.47.2/src/runtime.rs:719:13:
snapshot assertion for 'x_test_skip_tests' failed in line 66
---- core::builder::cli_paths::tests::x_test_skip_tests stdout end ----
---- core::builder::cli_paths::tests::x_test_skip_tests_coverage stdout ----
Running test in /tmp/.tmp29HrP4
cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-gnu-gcc": No such file or directory (os error 2)
cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-gnu-g++": No such file or directory (os error 2)
cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-gnu-g++": No such file or directory (os error 2)
Skipping Suite(test::tests/coverage) because it is excluded
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Snapshot Summary ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Snapshot file: src/bootstrap/src/core/builder/cli_paths/snapshots/x_test_skip_tests_coverage.snap
Snapshot: x_test_skip_tests_coverage
Source: src/bootstrap/src/core/builder/cli_paths/tests.rs:66
────────────────────────────────────────────────────────────────────────────────
Expression: test --skip=tests/coverage
────────────────────────────────────────────────────────────────────────────────
-old snapshot
+new results
---
   76    77 │     - Set({test::compiler/rustc_builtin_macros})
────────────┴───────────────────────────────────────────────────────────────────
Stopped on the first failure. Run `cargo insta test` to run all snapshots.

thread 'core::builder::cli_paths::tests::x_test_skip_tests_coverage' (4776) panicked at /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/insta-1.47.2/src/runtime.rs:719:13:
snapshot assertion for 'x_test_skip_tests_coverage' failed in line 66
---- core::builder::cli_paths::tests::x_test_skip_tests_coverage stdout end ----
---- core::builder::cli_paths::tests::x_test_skip_tests_etc stdout ----
Running test in /tmp/.tmpFPaRDS
cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-gnu-gcc": No such file or directory (os error 2)
cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-gnu-g++": No such file or directory (os error 2)
cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-gnu-g++": No such file or directory (os error 2)
---
Skipping Suite(test::tests/run-make) because it is excluded
Skipping Suite(test::tests/run-make-cargo) because it is excluded
Skipping Set({test::library/stdarch/crates/intrinsic-test}) because it is excluded
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Snapshot Summary ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Snapshot file: src/bootstrap/src/core/builder/cli_paths/snapshots/x_test_skip_tests_etc.snap
Snapshot: x_test_skip_tests_etc
Source: src/bootstrap/src/core/builder/cli_paths/tests.rs:66
────────────────────────────────────────────────────────────────────────────────
Expression: test --skip=tests --skip=library --skip=tidyselftest
────────────────────────────────────────────────────────────────────────────────
-old snapshot
+new results
---
   24    25 │     - Set({test::compiler/rustc_builtin_macros})
────────────┴───────────────────────────────────────────────────────────────────
Stopped on the first failure. Run `cargo insta test` to run all snapshots.

thread 'core::builder::cli_paths::tests::x_test_skip_tests_etc' (4798) panicked at /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/insta-1.47.2/src/runtime.rs:719:13:
snapshot assertion for 'x_test_skip_tests_etc' failed in line 66
---- core::builder::cli_paths::tests::x_test_skip_tests_etc stdout end ----
---- core::builder::tests::snapshot::check_compiler_no_explicit_stage stdout ----
Running test in /tmp/.tmp7UhcZb
##[group]Checking stage1 compiler artifacts{rustc-main, rustc_abi, rustc_arena, rustc_ast, rustc_ast_ir, rustc_ast_lowering, rustc_ast_passes, rustc_ast_pretty, rustc_attr_ir, rustc_attr_parsing, rustc_baked_icu_data, rustc_borrowck, rustc_builtin_macros, rustc_codegen_llvm, rustc_codegen_ssa, rustc_const_eval, rustc_data_structures, rustc_driver, rustc_driver_impl, rustc_error_codes, rustc_error_messages, rustc_errors, rustc_expand, rustc_feature, rustc_fs_util, rustc_graphviz, rustc_hashes, rustc_hir, rustc_hir_analysis, rustc_hir_id, rustc_hir_pretty, rustc_hir_typeck, rustc_incremental, rustc_index, rustc_index_macros, rustc_infer, rustc_interface, rustc_lexer, rustc_lint, rustc_lint_defs, rustc_llvm, rustc_log, rustc_macros, rustc_metadata, rustc_middle, rustc_mir_build, rustc_mir_dataflow, rustc_mir_transform, rustc_monomorphize, rustc_next_trait_solver, rustc_parse, rustc_parse_format, rustc_passes, rustc_pattern_analysis, rustc_privacy, rustc_proc_macro, rustc_public, rustc_public_bridge, rustc_query_impl, rustc_resolve, rustc_sanitizers, rustc_serialize, rustc_session, rustc_span, rustc_symbol_mangling, rustc_target, rustc_thread_pool, rustc_trait_selection, rustc_traits, rustc_transmute, rustc_ty_utils, rustc_type_ir, rustc_type_ir_macros, rustc_windows_rc} (stage0 -> stage1, aarch64-unknown-linux-gnu)
##[endgroup]
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Snapshot Summary ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Snapshot: check_compiler_no_explicit_stage
Source: src/bootstrap/src/core/builder/tests.rs:1776
────────────────────────────────────────────────────────────────────────────────
Expression: ctx.config("check").path("compiler").render_steps()
────────────────────────────────────────────────────────────────────────────────
-old snapshot
+new results
────────────┬───────────────────────────────────────────────────────────────────
    1       │-[check] rustc 0 <host> -> rustc 1 <host> (73 crates)
          1 │+[check] rustc 0 <host> -> rustc 1 <host> (74 crates)
────────────┴───────────────────────────────────────────────────────────────────
Stopped on the first failure. Run `cargo insta test` to run all snapshots.

thread 'core::builder::tests::snapshot::check_compiler_no_explicit_stage' (6920) panicked at /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/insta-1.47.2/src/runtime.rs:719:13:
snapshot assertion for 'check_compiler_no_explicit_stage' failed in line 1776
---
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Snapshot Summary ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Snapshot: check_compiler_stage_1
Source: src/bootstrap/src/core/builder/tests.rs:1801
────────────────────────────────────────────────────────────────────────────────
Expression: ctx.config("check").path("compiler").stage(1).render_steps()
────────────────────────────────────────────────────────────────────────────────
-old snapshot
+new results
────────────┬───────────────────────────────────────────────────────────────────
    1       │-[check] rustc 0 <host> -> rustc 1 <host> (73 crates)
          1 │+[check] rustc 0 <host> -> rustc 1 <host> (74 crates)
────────────┴───────────────────────────────────────────────────────────────────
Stopped on the first failure. Run `cargo insta test` to run all snapshots.

thread 'core::builder::tests::snapshot::check_compiler_stage_1' (6963) panicked at /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/insta-1.47.2/src/runtime.rs:719:13:
snapshot assertion for 'check_compiler_stage_1' failed in line 1801
---- core::builder::tests::snapshot::check_compiler_stage_1 stdout end ----
---- core::builder::tests::snapshot::check_compiler_stage_2 stdout ----
Running test in /tmp/.tmp7TOlxr
##[group]Building LLVM for aarch64-unknown-linux-gnu
##[endgroup]
##[group]Building stage1 compiler artifacts (stage0 -> stage1, aarch64-unknown-linux-gnu)
##[endgroup]
Creating a sysroot for stage1 compiler (use `rustup toolchain link 'name' build/host/stage1`)
---
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Snapshot Summary ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Snapshot: check_compiler_stage_2
Source: src/bootstrap/src/core/builder/tests.rs:1811
────────────────────────────────────────────────────────────────────────────────
Expression: ctx.config("check").path("compiler").stage(2).render_steps()
────────────────────────────────────────────────────────────────────────────────
-old snapshot
+new results
────────────┬───────────────────────────────────────────────────────────────────
    1     1 │ [build] llvm <host>
    2     2 │ [build] rustc 0 <host> -> rustc 1 <host>
    3     3 │ [build] rustc 1 <host> -> std 1 <host>
    4       │-[check] rustc 1 <host> -> rustc 2 <host> (73 crates)
          4 │+[check] rustc 1 <host> -> rustc 2 <host> (74 crates)
────────────┴───────────────────────────────────────────────────────────────────
Stopped on the first failure. Run `cargo insta test` to run all snapshots.

thread 'core::builder::tests::snapshot::check_compiler_stage_2' (6964) panicked at /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/insta-1.47.2/src/runtime.rs:719:13:
snapshot assertion for 'check_compiler_stage_2' failed in line 1811
---- core::builder::tests::snapshot::check_compiler_stage_2 stdout end ----
---- core::builder::tests::snapshot::check_cross_compile stdout ----
Running test in /tmp/.tmpIkxitu
##[group]Building LLVM for aarch64-unknown-linux-gnu
##[endgroup]
##[group]Building stage1 compiler artifacts (stage0 -> stage1, aarch64-unknown-linux-gnu)
---
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Snapshot Summary ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Snapshot: check_cross_compile
Source: src/bootstrap/src/core/builder/tests.rs:1826
────────────────────────────────────────────────────────────────────────────────
Expression: ctx.config("check").targets(&[TEST_TRIPLE_1]).hosts(&[TEST_TRIPLE_1]).render_steps()
────────────────────────────────────────────────────────────────────────────────
-old snapshot
+new results
────────────┬───────────────────────────────────────────────────────────────────
    1     1 │ [build] llvm <host>
    2     2 │ [build] rustc 0 <host> -> rustc 1 <host>
    3     3 │ [build] rustc 1 <host> -> std 1 <host>
    4     4 │ [check] rustc 1 <host> -> std 1 <target1>
    5       │-[check] rustc 1 <host> -> rustc 2 <target1> (73 crates)
          5 │+[check] rustc 1 <host> -> rustc 2 <target1> (74 crates)
    6     6 │ [check] rustc 1 <host> -> rustc 2 <target1>
    7     7 │ [check] rustc 1 <host> -> Rustdoc 2 <target1>
    8     8 │ [check] rustc 1 <host> -> rustc_codegen_cranelift 2 <target1>
    9     9 │ [check] rustc 1 <host> -> rustc_codegen_gcc 2 <target1>
────────────┴───────────────────────────────────────────────────────────────────
Stopped on the first failure. Run `cargo insta test` to run all snapshots.

thread 'core::builder::tests::snapshot::check_cross_compile' (7073) panicked at /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/insta-1.47.2/src/runtime.rs:719:13:
snapshot assertion for 'check_cross_compile' failed in line 1826
---
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Snapshot Summary ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Snapshot: check_library_skip_without_download_rustc-2
Source: src/bootstrap/src/core/builder/tests.rs:1927
────────────────────────────────────────────────────────────────────────────────
Expression: ctx.config("check").paths(&["library", "compiler"]).args(&args).render_steps()
────────────────────────────────────────────────────────────────────────────────
-old snapshot
+new results
────────────┬───────────────────────────────────────────────────────────────────
    1       │-[check] rustc 0 <host> -> rustc 1 <host> (73 crates)
          1 │+[check] rustc 0 <host> -> rustc 1 <host> (74 crates)
────────────┴───────────────────────────────────────────────────────────────────
Stopped on the first failure. Run `cargo insta test` to run all snapshots.

thread 'core::builder::tests::snapshot::check_library_skip_without_download_rustc' (7218) panicked at /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/insta-1.47.2/src/runtime.rs:719:13:
snapshot assertion for 'check_library_skip_without_download_rustc-2' failed in line 1927
---- core::builder::tests::snapshot::check_library_skip_without_download_rustc stdout end ----

failures:
    core::builder::cli_paths::tests::x_bench
    core::builder::cli_paths::tests::x_build_compiler
    core::builder::cli_paths::tests::x_check

rust-bors · 2026-07-26T10:31:26Z

☔ The latest upstream changes (presumably #159942) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

mejrs · 2026-07-28T12:43:02Z

(best done split up in multiple PRs)

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 24, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Jul 24, 2026

Auto merge of #159870 - mejrs:move_attrs, r=<try>

5bfd159

[perf] move attrs out of rustc_hir

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 25, 2026

mejrs added 2 commits July 25, 2026 11:20

move stuff

50acd9f

fix everything

539d4a6

mejrs force-pushed the move_attrs branch from 58e623d to 539d4a6 Compare July 25, 2026 09:20

mejrs closed this Jul 28, 2026

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 28, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[perf] move attrs out of rustc_hir - #159870

[perf] move attrs out of rustc_hir#159870
mejrs wants to merge 2 commits into
rust-lang:mainfrom
mejrs:move_attrs

mejrs commented Jul 24, 2026

Uh oh!

mejrs commented Jul 24, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Jul 25, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Jul 25, 2026

Uh oh!

rust-log-analyzer commented Jul 25, 2026

Uh oh!

rust-bors Bot commented Jul 26, 2026

Uh oh!

mejrs commented Jul 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

mejrs commented Jul 24, 2026

Uh oh!

mejrs commented Jul 24, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Jul 25, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Jul 25, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

rust-log-analyzer commented Jul 25, 2026

Uh oh!

rust-bors Bot commented Jul 26, 2026

Uh oh!

mejrs commented Jul 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants