rustc_incremental: avoid ICE when dumping dep graph fails - #159507
Open
cuishuang wants to merge 1 commit into
Open
rustc_incremental: avoid ICE when dumping dep graph fails#159507cuishuang wants to merge 1 commit into
cuishuang wants to merge 1 commit into
Conversation
Collaborator
|
r? @wesleywiser rustbot has assigned @wesleywiser. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
|
☔ The latest upstream changes (presumably #160102) made this pull request unmergeable. Please resolve the merge conflicts by rebasing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Zdump-dep-graphusedunwrap()when creating or writing the dependency graph output files. As a result, settingRUST_DEP_GRAPHto a path whose parent directory does not exist, or to another unwritable location, caused rustc to ICE.This changes
dump_graphto propagate filesystem errors and emit the existing structured file-writing diagnostic at the caller.The run-make test now covers an invalid output directory and verifies that rustc reports a normal error without ICEing.
Tests:
./x test tests/run-make/dep-graph./x fmt --check./x test tidy