disallow extern "custom" on wasm and spirv targets#158621
Open
folkertdev wants to merge 4 commits into
Open
Conversation
rustbot
added
S-waiting-on-author
Member
|
I think it would make sense to deny on spirv, but native gpu archs are not typed and thus can handle custom ABIs just fine. |
Contributor
Author
|
cc @tgross35 r? bjorn3 |
folkertdev
changed the title
extern "custom" on wasm targetsextern "custom" on wasm and spirv targets
Collaborator
|
These commits modify compiler targets. |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
folkertdev
force-pushed
the
abi-custom-wasm
branch
from
341bd82 to
2cafd26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tracking issue: #140829
I'm not sure if we should exclude any other architectures? The GPU ones are a bit suspect maybe?