Move std::io::read_to_string to alloc::io#158545
Open
bushrat011899 wants to merge 12 commits into
Open
Conversation
Collaborator
|
r? @jhpratt rustbot has assigned @jhpratt. Use Why was this reviewer chosen?The reviewer was selected based on:
|
rustbot
added
S-waiting-on-review
Contributor
Author
|
@rustbot blocked |
rustbot
added
S-blocked
This was referenced Jun 29, 2026
This comment has been minimized.
This comment has been minimized.
bushrat011899
force-pushed
the
alloc_io_read_to_string
branch
from
63e0a84 to
553848d
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bushrat011899
force-pushed
the
alloc_io_read_to_string
branch
2 times, most recently
from
e9c0d4c to
7c579fc
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bushrat011899
force-pushed
the
alloc_io_read_to_string
branch
from
7c579fc to
81c200e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bushrat011899
force-pushed
the
alloc_io_read_to_string
branch
from
81c200e to
9764316
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bushrat011899
force-pushed
the
alloc_io_read_to_string
branch
from
9764316 to
5fd480e
Compare
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Clar Fon <15850505+clarfonthey@users.noreply.github.com>
Co-Authored-By: Clar Fon <15850505+clarfonthey@users.noreply.github.com>
Moves unsafe code from `alloc::io` into `alloc::vec`. A more general `try_extend_from_slice` may be useful in the future, but that requires changing how specialization is done for `SpecExtend` and that's a lot for an internal-only function.
bushrat011899
force-pushed
the
alloc_io_read_to_string
branch
from
5fd480e to
45a5755
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ACP: rust-lang/libs-team#755
Tracking issue: #154046
Split From: #156527
Blocked On: #158544
Description
Moves
std::io::read_to_stringtoalloc::io. This is a trivial move. Blocked on #158544.Notes
alloc::ioandcore::io#154046 (comment) for a review order and broader context for this PR.