lints: constant_bool_expr: detect constant booleans expressions using && or ||#17417
Open
poliorcetics wants to merge 2 commits into
Conversation
rustbot
added
the
S-waiting-on-community-reviews
Collaborator
|
Thanks for the pull request, and welcome! You should hear from one of our reviewers after this PR gets at least 2 reviews from the community. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
needs-fcp
poliorcetics
force-pushed
the
ab/lints-constant-bool-expr-add-support-for-rudimentary-const-eval/lukkmqzkzmuq
branch
from
93b4f6c to
4e3aa57
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
… `&&` or `||` For now this only detects simple cases using literals.
poliorcetics
force-pushed
the
ab/lints-constant-bool-expr-add-support-for-rudimentary-const-eval/lukkmqzkzmuq
branch
from
4e3aa57 to
7a35b90
Compare
poliorcetics
force-pushed
the
ab/lints-constant-bool-expr-add-support-for-rudimentary-const-eval/lukkmqzkzmuq
branch
from
7a35b90 to
77a7856
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detects expressions of the form
a != b || a != cora == b && a == c(wherea,b, andcare all unique expressions) to warn about them: they evaluate either always totrueor always tofalse, which is very likely a logic bug.Closes #853
changelog: [
constant_bool_expr]: detect constant booleans expressions using&&or||