clippy: avoid invalid ref_as_ptr suggestions in const/static initializers#17415
Merged
Merged
Conversation
rustbot
added
the
S-waiting-on-community-reviews
Collaborator
|
Thanks for the pull request, and welcome! You should hear from one of our reviewers after this PR gets at least 2 reviews from the community. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-review
Extend the existing const/static guard to also handle nested cast expressions. This prevents \ ef_as_ptr\ from suggesting \ptr::from_ref\/\ptr::from_mut\ replacements that fail during const evaluation.
rabindra789
force-pushed
the
fix/ref-as-ptr-const-static
branch
from
906d12f to
d728c37
Compare
rabindra789
changed the title
ref_as_ptr suggestions in const/static initializers
rustbot
added
the
S-waiting-on-review
poliorcetics
approved these changes
Jul 13, 2026
DanielEScherzer
approved these changes
Jul 13, 2026
rustbot
removed
the
S-waiting-on-community-reviews
Collaborator
|
r? @llogiq rustbot has assigned @llogiq for the project review. Use Why was this reviewer chosen?The reviewer was selected based on:
|
llogiq
approved these changes
Jul 15, 2026
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13910.
ref_as_ptrcan suggeststd::ptr::from_ref/std::ptr::from_mutfor nested reference-to-raw-pointer casts insideconstandstaticinitializers. The suggested replacement then fails during const evaluation.The existing guard only checks the immediate expression use site, which misses nested cast expressions. Extend it to also check whether the expression is inside an always-const context using
is_inside_always_const_context.Testing
static mutcase.ref_as_ptrUI tests.changelog: [
ref_as_ptr]: avoid invalid suggestions in const/static initializers