Clarify FCP requirements and best practices - #382
Merged
tmandry merged 1 commit intoJul 3, 2026
Conversation
Member
|
FWIW I think it should be ~trivial to adjust rust-lang/team to grant lang-advisors rfcbot permissions (probably add something like https://github.com/rust-lang/team/blob/main/teams/lang.toml#L34-L37 to lang-advisors?), if they don't have them already through some team (many will). |
Member
Author
|
Lang nominated to collect feedback. I get questions about our docs on a regular basis, and I know we sometimes struggle with what people outside the team bring us. Making these docs legible to people outside the team can smooth out our interactions quite a lot, so we might as well invest time in getting them right. |
tmandry
commented
Jul 3, 2026
tmandry
force-pushed
the
never-send-to-know-for-whom-the-rfcbot-fcps
branch
from
July 3, 2026 23:05
a5b62d0 to
3967c3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is prompted by the change in rust-lang/rfcbot-rs#352.
The existing wording, added in #360, said that lang members and advisors start FCPs. This was misleading because previously only lang members could start an FCP, and it still isn't the case that every advisor can start an FCP. I interpret the existing wording as our intended process, so this PR updates the wording to reflect that more clearly.
Other changes:
These changes are meant to reflect what we do today but make it legible to people outside the team.