NEED REVIEW : Correct workflow yml files - #123
Open
MykolaMS9 wants to merge 1 commit into
Open
Conversation
- change runs-on value: add possibility to chose custom runner label - add sha
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
Update GitHub Actions workflows to:
ubuntu-latest.Solution
runs-on: ubuntu-latestwithruns-on: ${{ vars.GH_RUNNER_LABEL_CI || 'ubuntu-latest' }}inci.yml,students_ci.ymlandstudents_tool_cache.yml. This lets CI switch to a custom runner by setting theGH_RUNNER_LABEL_CIrepository/organization variable, while still defaulting toubuntu-latestwhen it's not set (GitHub Actions expressions treat an unsetvars.*as an empty, falsy string, so||works as a default-value operator here).uses:action reference to its full commit SHA, with a# <version>comment for readability:actions/checkout@v3/@v4→@9c091bb...(v7.0.0)gaurav-nelson/github-action-markdown-link-check@v1→@3c3b66f...(1.0.17) — thev1tag turned out to be frozen on a 2022 commit and no longer tracks the maintainer's actual releases.Swatinem/rust-cache@v2→@e18b497...(v2.9.1)actions-rs/toolchain@v1withdtolnay/rust-toolchain(pinned to SHA), because theactions-rsGitHub org was archived in October 2023 and the action is unmaintained (relies on deprecated Node.js runtimes). Updated the dependent cache key fromsteps.rust.outputs.rustc_hashtosteps.rust.outputs.cachekey, since the new action exposes the cache key under a different output name.