Add EBS VolumeId to disk metrics - #44
Open
crohr wants to merge 1 commit into
Open
Conversation
crohr
marked this pull request as ready for review
July 10, 2026 14:04
Contributor
Author
|
Pushback review pass — this PR is in good shape. Focused diff, the sysfs serial resolution is properly restricted before joining user input to a privileged path ( Two non-blocking notes:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VolumeIdbacking the configured Nitro NVMe diskvolume_idaction outputVolumeId-qualified metric across the x64/arm64 metrics matrixWhy
Disk-capacity metrics currently identify an instance and mount path, but not the live EBS volume created from the snapshot. That forces alert responders to perform a separate instance-to-volume lookup. PR #28 attempted to add the query dimension without configuring CloudWatch Agent to publish the same metric identity; this change implements both sides and preserves the existing fallback when a volume cannot be resolved.
Validation
go test ./...action.ymland the metrics workflowbash -non the workflow verification scriptgit diff --checkupx -t main-linux-amd64 main-linux-arm64 main-windows-amd64.exeThe metrics workflow now polls CloudWatch using instance-profile credentials and fails unless
disk_used_percentreturns data for the exactInstanceId,VolumeId,fstype, andpathdimensions.go vet ./...continues to report the pre-existing unreachable code inenableDetailedMonitoring; this PR does not change that behavior.