Skip to content

feat: Add support for @ts-ignore flag #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
milutin wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: Add support for @ts-ignore flag #395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
88d8e56
Master
milutin Aug 4, 2025
f0b9751
feat: add ts-ignore flag support
milutin Aug 5, 2025
ee74b31
Merge branch 'runem:master' into feature/ts-ignore-flag
milutin Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions packages/lit-analyzer/src/lib/analyze/parse/tagged-template/find-tagged-templates.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { Node, SourceFile, TaggedTemplateExpression } from "typescript";
import { tsModule } from "../../ts-module.js";
import { findParent, getNodeAtPosition } from "../../util/ast-util.js";
import { findParent, getNodeAtPosition, leadingCommentsIncludes } from "../../util/ast-util.js";
import { TS_IGNORE_FLAG } from "../../constants.js";

/**
* Returns all virtual documents in a given file.
Expand Down Expand Up @@ -51,9 +52,10 @@ export function visitTaggedTemplateNodes(astNode: Node, context: TaggedTemplateV
const newContext = { ...context };
if (tsModule.ts.isTaggedTemplateExpression(astNode) && context.shouldCheckTemplateTag(astNode.tag.getText())) {
// Only visit the template expression if the leading comments does not include the ts-ignore flag.
//if (!leadingCommentsIncludes(astNode.getSourceFile().getText(), astNode.getFullStart(), TS_IGNORE_FLAG)) {
newContext.parent = astNode;
context.emitTaggedTemplateNode(astNode);
if (!leadingCommentsIncludes(astNode.getSourceFile().getText(), astNode.getFullStart(), TS_IGNORE_FLAG)) {
newContext.parent = astNode;
context.emitTaggedTemplateNode(astNode);
}
}

astNode.forEachChild(child => visitTaggedTemplateNodes(child, context));
Expand Down
5 changes: 5 additions & 0 deletions packages/lit-analyzer/src/test/rules/no-unclosed-tag.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,8 @@ tsTest("Don't report self closed tags", t => {
const { diagnostics } = getDiagnostics("html`<img />`", { rules: { "no-unclosed-tag": true } });
hasNoDiagnostics(t, diagnostics);
});

tsTest("Don't report unclosed tags when it's been ignored", t => {
const { diagnostics } = getDiagnostics("// @ts-ignore\nhtml`<div>`", { rules: { "no-unclosed-tag": true } });
hasNoDiagnostics(t, diagnostics);
});
Loading