Show the Runner Gallery link in an info popover - #81
Merged
Conversation
The Custom Runners section carried the Runner Gallery link in a section footer built from an AttributedString, styling the link range by hand. Move it behind the same info button the Custom Metrics section already uses, and rename that section's help popover state and action to "info" so both sections name the affordance after the button the user taps. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context of Contribution
Summary of the Proposal
The Custom Runners section carried the Runner Gallery link in a section footer built from an
AttributedString, which located the substring"Runner Gallery"at runtime and styled the link range by hand. That approach breaks silently whenever a translation does not contain the literal"Runner Gallery".This PR moves the link behind an info button, matching the affordance the Custom Metrics section already had:
CustomRunnerSettingsgainsshowingInfoPopoverand aninfoButtonTappedAction; the footer is replaced by aninfo.circlebutton with a popover holdingrunnerGalleryDescriptionand a realLinkto the gallery.CustomMetricsSettingsrenamesshowingHelpPopover/helpButtonTappedtoshowingInfoPopover/infoButtonTapped, so both sections name the affordance after the button the user actually taps.Labelwith.labelStyle(.iconOnly), so the icon carries an accessibility label instead of being an unlabeledImage.CustomMetricsSettingsSectionView,.fileImporterand.confirmationDialogmove onto the views that actually own them (the add button and the list) instead of hanging off the enclosingHStack/List.informationandviewRunnerGallery.infoButtonTappedfor both stores.Reason for the new feature
N/A — this is a refactor of an existing affordance, not a new feature.
Verification
Xcode build succeeded, and the
UnitTesttest plan passes in full: 172 tests, 172 passed, 0 failed.Checklist
DependencyClient, no logic inUserInterfaceviews, no Asset/String Catalog references fromModel.🤖 Generated with Claude Code