feat: extract user dependent main nav to client side#1180
Open
salzig wants to merge 3 commits into
Open
Conversation
salzig
force-pushed
the
feat/extract_user_dependent_main_nav_to_client_side
branch
from
b9e9a10 to
ae7ecf9
Compare
Member
|
I think this is the thing with caching the site right? For me the javascript part looks a bit "hacky". Wouldn't it possible to use turbo + Stimuls for that or is this really the best way? |
Collaborator
Author
yeah, the general idea is to get into the general direction of stimulus, but wasn't convinced yet to add "stimulus-rails" and "importmap-rails" to our dependencies just yet. I'd like to removed dependencies to jQuery before tackling that horse. |
JoschkaSchulz
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.