Skip to content

fix: Ensure we exit after saying Bye Bye #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bougyman merged 3 commits into from
Aug 15, 2025
Merged

fix: Ensure we exit after saying Bye Bye #33

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e4ddf8b
fix: Ensure we exit after saying Bye Bye
bougyman Aug 15, 2025
a454f68
fix: Gives a more relevant error code on exit
bougyman Aug 15, 2025
01b8d19
fix: Corrects the method documentation (nod Thibs)
bougyman Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/leopard/nats_api_server.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ def shutdown(workers, pool)
logger.warn 'Pool is shut down, waiting for termination!'
pool.wait_for_termination
logger.warn 'Bye bye!'
wake_main_thread
wake_main_thread_and_exit!
end
end

Expand All @@ -165,10 +165,12 @@ def trap_signals(workers, pool)
# If the main thread is not blocked, this method does nothing.
#
# @return [void]
def wake_main_thread
def wake_main_thread_and_exit!
Thread.main.wakeup
rescue ThreadError
nil
ensure
exit
Comment thread
bougyman marked this conversation as resolved.
Outdated
end
end

Expand Down