Fix NoMethodError in MethodAttr#inspect for cache-loaded aliases#1747
Open
SAY-5 wants to merge 1 commit into
Open
Fix NoMethodError in MethodAttr#inspect for cache-loaded aliases#1747SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MethodAttr#inspectcalls@is_alias_for.namedirectly, but for a method loaded from the ri cache@is_alias_foris still the unresolved[class, singleton, name]tuple, so callinginspect(e.g.p driver.stores.first.load_method("Array", "#append")) raisesNoMethodError: undefined method 'name' for an instance of Array.This mirrors the guard
pretty_printalready uses in the same file: use the resolved object's name when available, otherwise fall back to the method name from the tuple.Closes #1737.