-
Notifications
You must be signed in to change notification settings - Fork 6
Mask as a struct attribute. #304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yfukai
wants to merge
47
commits into
royerlab:main
Choose a base branch
from
yfukai:mask_struct_attr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 40 commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
29177f3
added private metadata machinery
yfukai d8292f1
before adding private
yfukai cff5898
added private metadata view
yfukai 68b01d4
renamed func
yfukai 1ae2426
implementation of saving and loading dtypes as metadata
yfukai c50a07b
lint
yfukai e9bf28f
restricted dtype metadata to sqlgraph
yfukai 9aa9c3a
udpated serialization strategies
yfukai 7e61ac3
solved failing tests
yfukai e5968bf
added test for shape-less pl.Array (xfail)
yfukai b4acde3
working
yfukai cc55976
simplified code
yfukai e76d8e5
initial try
yfukai 7bec369
saving private metadata
yfukai 852f717
rustworkx reviewed
yfukai 4c151bb
Merge branch 'from_other_roundtrip' into struct_attr
yfukai 4af9904
working with clean code?
yfukai 19055ab
Merge branch 'main' into struct_attr
JoOkuma 6c69e76
updated impl
yfukai d9bee26
removed codex config wrongly added
yfukai cc0beb4
issue fixes
yfukai 007d4c7
Merge branch 'main' into struct_attr
yfukai ffea2ec
rolled back unncessary change
yfukai 0ad6c60
Merge remote-tracking branch 'upstream/main' into struct_attr
yfukai 5e7331f
additional comments
yfukai 7e07801
Merge branch 'main' into struct_attr
JoOkuma 37f8fc9
Fix lint: remove whitespace from blank lines
JoOkuma 1842c55
fixes
yfukai db35287
refactor aligning main
yfukai 3759d9c
Restore scratch-table machinery and tests from main
yfukai f5b7cc0
Merge branch 'main' of https://github.com/royerlab/tracksdata into st…
yfukai 0d76262
ignored the devcontaienr
yfukai 87707d0
bugfix
yfukai 9ba99e1
Store Mask as a struct attribute instead of pickled pl.Object
yfukai e7f99af
Merge upstream/main into mask_struct_attr
yfukai 7d02b80
Store binary attributes as raw BLOB in SQL instead of pickling
yfukai 00f41eb
Clean up mask struct-attribute branch for review
yfukai 07b68c6
Document why as_mask imports are function-local
yfukai 1a6ad08
updating name and adding comments
yfukai a21dd31
adding test
yfukai 81a473e
Merge remote-tracking branch 'upstream/main' into mask_struct_attr
yfukai 0821359
Replace Mask class with a TypedDict and module-level functions
yfukai 61c4ba2
Make Mask a frozen dataclass instead of a TypedDict
yfukai 1231a9e
Fix CI lint against newer ruff versions
yfukai 607d258
Pin witty away from 0.3.2 to fix the C extension build
yfukai 594d3bf
Merge branch 'main' into mask_struct_attr
JoOkuma e84def5
Update src/tracksdata/graph/_sql_graph.py
yfukai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could remove this now, that's trivial to just write it