Skip to content

Upgrade dependencies & Add JSDoc & Some cleanup#7

Open
tspoke wants to merge 5 commits into
rowanwins:masterfrom
tspoke:master
Open

Upgrade dependencies & Add JSDoc & Some cleanup#7
tspoke wants to merge 5 commits into
rowanwins:masterfrom
tspoke:master

Conversation

@tspoke

@tspoke tspoke commented Jun 14, 2023

Copy link
Copy Markdown

Hi @rowanwins !

As you suggested in my issue on turfjs, here is a pull-request with some changes :

  • Dependencies upgrade to latest
  • Fixed some test
  • Make the benchmark works again
  • Add JSDoc to all functions and methods
  • Refactorized a file to a class (GeoJsonHelper)
  • Refactorized some method visibility

This PR can be a breaking change for consumers as some exported functions are not anymore exported (I don't think anybody used internal exported functions IMO).

@rowanwins

Copy link
Copy Markdown
Owner

Thanks for this @tspoke - from my quick look it all looks good but I'll need to take a more thorough look before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants