Skip to content

insights: the self-removed-credit finding still shows a saving context-guru did not make #584

Open

Description

@amiddavid

Summary

/context-guru:insights still shows a dollar figure for what the account removed by itself: the self-removed-credit finding. The repo owner decided in #583 that a saving context-guru did not make is not shown as ours. #583 removed the self_removed row from the levers table. This finding is the one place left.

What we found

  • context-guru-plugin/scripts/insights.py:856-880 reads tools.self_removed and adds the finding self-removed-credit (severity ok): "You already removed N capability(ies), and it worked ... $X avoided over D days".
  • It never goes into a saved total. The findings list ranks it by its own dollar figure (usd_window, usd_month), so it can appear high in the list.
  • It sets the facts self_removed_items and self_removed_usd.
  • The Codex plugin has no copy of insights.py (checked in the fix(plugin): insights shows savings with the right sign #583 review).

Decision

The repo owner, on #583: "what Claude removes is not our concern, remove the row." In the levers table, self_removed is gone.

Open question for the assignee

The code comment calls this "a saving the product caused": a server stops being declared, for example after /context-guru:remove-mcp-and-skills recommended removing it. If the removal came from our own recommendation, it is arguably our saving, and #537 already measures "savings since removal" for that command. Please choose one, and confirm it with the repo owner:

  1. Remove the self-removed-credit finding and its facts, in line with fix(plugin): insights shows savings with the right sign #583. Or
  2. Keep only the removals that /context-guru:remove-mcp-and-skills recommended (the feat(dash): remove-mcp-and-skills backend: one question, measured savings since removal #537 measurement), and drop the rest.

Proposal

  • Change insights.py, its tests and its goldens to match the choice.
  • Add a test: a window with a non-zero self_removed produces no finding with a dollar figure (option 1), or only the recommended ones (option 2).

Related: #582, #583.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions