Skip to content

fix(hero): render localized heading lines #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roschaefer merged 1 commit into from
Aug 13, 2026
Merged

fix(hero): render localized heading lines #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions messages/de.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,10 @@
"theme_use_light": "Helles Farbschema verwenden",
"theme_use_dark": "Dunkles Farbschema verwenden",
"hero_role": "Full Stack Developer",
"hero_title": "Software Qualität",
"hero_accent": "sichtbar gemacht.",
"hero_heading_line_1": "Software",
"hero_heading_line_2": "Qualität",
"hero_heading_line_3": "sichtbar",
"hero_heading_line_4": "gemacht.",
"hero_browse_projects": "Projekte ansehen",
"hero_contact": "Kontakt aufnehmen",
"cv_pdf_download": "CV als PDF laden",
Expand Down
6 changes: 4 additions & 2 deletions messages/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,10 @@
"theme_use_light": "Use light color theme",
"theme_use_dark": "Use dark color theme",
"hero_role": "Full Stack Developer",
"hero_title": "Software quality",
"hero_accent": "made visible.",
"hero_heading_line_1": "Software",
"hero_heading_line_2": "quality",
"hero_heading_line_3": "made",
"hero_heading_line_4": "visible.",
"hero_browse_projects": "Browse projects",
"hero_contact": "Get in touch",
"cv_pdf_download": "Download CV (PDF)",
Expand Down
20 changes: 16 additions & 4 deletions src/lib/components/PortfolioPage.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,10 +245,22 @@ markUsed(() => [
class="grid gap-10 xl:grid-cols-[minmax(0,1.35fr)_minmax(24rem,0.9fr)]"
>
<div class="min-w-0 space-y-8">
<h1 id="intro-title" class="hero-heading theme-heading max-w-4xl" lang={locale}>
{t(m.hero_title)}
<br />
<span class="text-[var(--color-brand-cyan)]">{t(m.hero_accent)}</span>
<h1
id="intro-title"
class="hero-heading theme-heading max-w-4xl max-[23rem]:text-5xl"
lang={locale}
aria-label={`${t(m.hero_heading_line_1)} ${t(m.hero_heading_line_2)} ${t(m.hero_heading_line_3)} ${t(m.hero_heading_line_4)}`}
>
<span aria-hidden="true">
<span class="block">{t(m.hero_heading_line_1)}</span>
<span class="block">{t(m.hero_heading_line_2)}</span>
<span class="block text-[var(--color-brand-cyan)]">
{t(m.hero_heading_line_3)}
</span>
<span class="block text-[var(--color-brand-cyan)]">
{t(m.hero_heading_line_4)}
</span>
</span>
</h1>
<p class="text-lg text-[var(--color-brand-text)]">{content.basics.summary}</p>
<ul class="flex list-none flex-wrap gap-4 p-0">
Expand Down
Loading