Skip to content

Run RMW tests in isolation and call shutdown on error (backport #2460) - #2462

Closed
mergify[bot] wants to merge 1 commit into
kiltedfrom
mergify/bp/kilted/pr-2460
Closed

Run RMW tests in isolation and call shutdown on error (backport #2460)#2462
mergify[bot] wants to merge 1 commit into
kiltedfrom
mergify/bp/kilted/pr-2460

Conversation

@mergify

@mergify mergify Bot commented Jul 23, 2026

Copy link
Copy Markdown

Description

Addresses parts of # ros2/rmw_zenoh#1016

Is this user-facing behavior change?

No

Did you use Generative AI?

Yes, Claude Opus 4.8 to identify which tests need to be updated.

Additional Information


This is an automatic backport of pull request #2460 done by [Mergify](https://mergify.com).

Signed-off-by: Yadunund Vijay <yadunund@gmail.com>
(cherry picked from commit 2777970)

# Conflicts:
#	rosbag2_py/src/rosbag2_py/_transport.cpp
@mergify

mergify Bot commented Jul 23, 2026

Copy link
Copy Markdown
Author

Cherry-pick of 2777970 has failed:

On branch mergify/bp/kilted/pr-2460
Your branch is up to date with 'origin/kilted'.

You are currently cherry-picking commit 2777970.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   rosbag2_py/CMakeLists.txt
	modified:   rosbag2_tests/CMakeLists.txt
	modified:   rosbag2_tests/package.xml

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   rosbag2_py/src/rosbag2_py/_transport.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@ahcorde

ahcorde commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Pulls: #2462
Gist: https://gist.githubusercontent.com/ahcorde/2989621a2b6bbe15a8f2909ae1251dae/raw/0e76dd0247879791a0174f6861c711b88770bdd4/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_py rosbag2_tests --cmake-args -DRMW_IMPLEMENTATION=rmw_zenoh_cpp
TEST args: --packages-above rosbag2_py rosbag2_tests
ROS Distro: kilted
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19951

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde closed this Jul 28, 2026
@Yadunund

Copy link
Copy Markdown
Member

@ahcorde did you plan on opening a different PR with conflicts resolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants